fix(mcp): consume self-cancelling JSON-RPC batches - #3076
Open
fahreddinozcan wants to merge 1 commit into
Open
Conversation
|
Docs7 preview for context7.com
|
fahreddinozcan
force-pushed
the
codex/ctx7-2472-reject-self-cancelling-batches
branch
from
August 25, 2026 09:17
1c5a1fb to
2b8f727
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
@modelcontextprotocol/server@2.0.0correctly suppresses a response afternotifications/cancelled, but its legacy stateless HTTP transport closes a batch stream only after its response map contains every request ID registered for that stream. Cancellation does not remove or settle the mapped ID, so a self-cancelling batch stays open indefinitely.The application-side filter preserves MCP cancellation semantics: cancelled requests produce no response, do no tool/backend work, and do not enter the SDK transport response accounting.
This closes Cobalt finding
PT38659_18(CWE-400).Linear: CTX7-2472
Verification
time=0.008391s http=202 bytes=0 exit=0pnpm --dir packages/mcp typecheckpnpm --dir packages/mcp lint:checkpnpm --dir packages/mcp exec vitest run --exclude "dist/**"(82 tests)git diff --check