Add Linux ROCm and Vulkan legs to the prebuilt pipeline, so AMD hosts stop landing on the CPU build - #14
Open
LeoBorcherding wants to merge 1 commit into
Open
Add Linux ROCm and Vulkan legs to the prebuilt pipeline, so AMD hosts stop landing on the CPU build#14LeoBorcherding wants to merge 1 commit into
LeoBorcherding wants to merge 1 commit into
Conversation
…g back to upstream or the CPU build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Studio's MiniMax-H3 GGUF path asks this mirror for an sd-cli built for
rocm. The latest release has none: macOS, Linux CPU, Linux CUDA, Linux aarch64, Windows CPU. So the installer falls back to leejet's upstream ROCm build, which doesn't carry the H3 fixes in this repo, and when that binary doesn't list a GPU,video.pydrops to the CPU build.That's unslothai/unsloth#8814:
7900 XTX on CachyOS, H3 goes
installedtoload_failedwithin a second. A Discord report this week on the same card and distro is the other shape of it: H3 Q3_K fills 30 GB of RAM and 36 GB of swap while VRAM sits at 1.5 GB.What this adds
Three legs in
unsloth-sd-prebuilt.yml, same rule as the CUDA leg:continue-on-error, not in the coverage gate, so they can never hold back the CPU and Apple assets.build-linux-vulkanLinux-Ubuntu-22.04-x86_64-vulkanbuild-linux-rocmLinux-Ubuntu-24.04-x86_64-rocm-7.14.0build-windows-vulkanwin-vulkan-x64, signed like the CPU legThe ROCm leg builds against TheRock wheels like upstream's
build.yml, but ships the ROCm userspace it linked against in the bundle: every librarylddresolves from the wheel tree, plusrocblas/library, rpath$ORIGIN, and it fails if anything is still unresolved with the wheel tree hidden. Upstream's zip doesn't do that, so it only runs on a host with a matching ROCm, which is the #8814 failure. Same shape as the ROCm leg in unslothai/llama.cpp.package_bundle.pykeepsrocblas/library(andhipblaslt/library) with their layout, since rocBLAS loads its kernels from next tolibrocblas. Everything else still lands flat.Asset names are what Studio's
resolve_release_assetalready matches forrocmandvulkan, so a ROCm host picks these up with no Studio change. Not here: Windows ROCm, and the Studio-side fallback fromrocmtovulkanbeforecpu(separate PR in unslothai/unsloth).Test matrix
This workflow only runs on schedule and
workflow_dispatch, so nothing on this PR exercises it.assemble.needs, eachcontinue-on-errorpackage_bundle.pyon a fake bin tree:sd-cli, nestedsd-server,libamdhip64.so.7,rocblas/library/*.dat, a straynotes.txtworkflow_dispatchwithpublish: false,keep_artifacts: truelddgate in the leg is the only proof it stands aloneSolid: packaging and workflow shape. Not proven: that any leg builds, or that the ROCm bundle runs H3 on a real card.