Repository navigation
Conversation
GitHub closes a linked issue when its PR reaches the DEFAULT branch. Here that is `main`, while the work merges to `development`, and merges to `main` are infrequent. So between a merge and a release an issue is fixed and still open, and nothing in the repository says so. The mechanism itself is sound: across the project's life 139 declared closes produced 5 that slipped. It is release-gated, not broken, and it was worth establishing that before adding anything -- the backlog was not caused by it. `fixed-in-development` is applied at merge and the release closes everything carrying it in one pass. Closing at merge stays a reasonable choice for a defect nobody outside is waiting on; it is only misleading for one somebody is. scripts/triage.py now lists every issue a merged PR declared that is neither closed nor labelled, and names three outcomes rather than two. The third is the reason the list is candidates and not fixes: #611 was credited to #656 and its hang is handled by a `--deselect` in scripts/test.sh at the very rank count the issue reports. The tool finds exactly that one today. Underworld development team with AI support from Claude Code
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused workflow and documentation changes are consistent and syntactically valid.
Review effort: Balanced
Findings: None
What changed in this PR
Adds workflow visibility for issues fixed on development but not yet released.
Changes:
- Reports merged PRs whose declared issues remain open and unlabelled.
- Documents the
fixed-in-developmentlifecycle and three triage outcomes.
| File | Description |
|---|---|
scripts/triage.py |
Adds label-aware issue triage. |
docs/developer/guides/adversarial-review.md |
Documents merge-to-release issue handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Superseded by #825. The label is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges to
mainare infrequent, so GitHub's issue-closing — which fires only on adefault-branch merge — lags reality by a release. Between a merge and a release an
issue is fixed and still open and nothing says so.
Worth establishing first: the mechanism is not broken. Across the project's life
139 declared closes produced 5 that slipped, so it works — it works at release
time. The backlog was not caused by it, and I had briefly concluded otherwise.
What this adds
fixed-in-development(label created), applied at merge; the release then closeseverything carrying it in one pass. Closing at merge stays a reasonable choice for a
defect nobody outside is waiting on — it is only misleading for one somebody is.
scripts/triage.pygains a section listing every issue a merged PR declared that isneither closed nor labelled:
Three outcomes, not two
The hint names a third, and #611 is why:
#611 is the standing example. #656 was credited with closing it. The hang is handled
by
scripts/test.sh:289:That deselect sits in the np=4 pass — the rank count the issue reports hanging at.
CI is green because the test does not run there. A tool that offered only close-or-label
would have labelled it and the hang would have gone quiet for good.
Underworld development team with AI support from Claude Code