Skip to content

improve-quality-job pr comment - #4609

Merged
je-cook merged 1 commit into
mainfrom
pr-comment-improve-quality-check-worse
Oct 1, 2026
Merged

improve-quality-job pr comment#4609
je-cook merged 1 commit into
mainfrom
pr-comment-improve-quality-check-worse

Conversation

@clmould

@clmould clmould commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Checklist

#4420

Will tidy up commit history before review

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould
clmould marked this pull request as ready for review September 22, 2026 16:29
@clmould
clmould requested a review from a team as a code owner September 22, 2026 16:29
@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch from 56bfbbf to e43ae70 Compare September 22, 2026 16:30
@clmould
clmould marked this pull request as draft September 22, 2026 16:30
@clmould clmould closed this Sep 22, 2026
@clmould clmould reopened this Sep 22, 2026
@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch 2 times, most recently from 2433527 to da60f35 Compare September 23, 2026 09:29
@codecov-commenter

codecov-commenter commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.92%. Comparing base (2ae0ef2) to head (a164764).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4609      +/-   ##
==========================================
- Coverage   49.97%   49.92%   -0.06%     
==========================================
  Files         151      151              
  Lines       29929    30236     +307     
==========================================
+ Hits        14956    15094     +138     
- Misses      14973    15142     +169

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

je-cook
je-cook reviewed Sep 24, 2026
View reviewed changes
Comment thread .github/workflows/process.yml Outdated
@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch 3 times, most recently from ad0a973 to 6bf09c1 Compare September 24, 2026 17:30
@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced $compared_errors more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced "$compared_errors" more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced $env.compared_errors more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

1 similar comment
@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch from e534d32 to d504a3d Compare September 28, 2026 14:18
@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

8 similar comments
@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced $"{{ steps.num_errors.outputs.compared_errors }}" more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced

more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced
-4
more linting errors when compared to main.
Please fix these

@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch from ed39973 to 384479b Compare October 1, 2026 10:58
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -77 more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -4 more linting errors when compared to main.
Please fix these

6 similar comments
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -4 more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -4 more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -4 more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -4 more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -4 more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -4 more linting errors when compared to main.
Please fix these

@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch from 10bb4e4 to 40a301a Compare October 1, 2026 12:56
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -4 more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced 0 more linting errors when compared to main.
Please fix these

1 similar comment
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced 0 more linting errors when compared to main.
Please fix these

@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch from 723369f to 40a301a Compare October 1, 2026 13:09
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -4 more linting errors when compared to main.
Please fix these

3 similar comments
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -4 more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -4 more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced -4 more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Files changed by this PR have introduced 3 more linting errors when compared to main.
Please fix these

@github-actions

github-actions Bot commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ improve_quality_job warning!

Files changed by this PR have introduced 3 more linting errors when compared to main

Please fix these

To check what these are, run hatch run lint:fmt_extra on your branch and on main

@clmould
clmould force-pushed the pr-comment-improve-quality-check-worse branch from e63615f to a164764 Compare October 1, 2026 14:03
@clmould
clmould marked this pull request as ready for review October 1, 2026 14:06
@je-cook
je-cook enabled auto-merge (squash) October 1, 2026 14:06
@je-cook
je-cook merged commit 4885172 into main Oct 1, 2026
11 checks passed
@je-cook
je-cook deleted the pr-comment-improve-quality-check-worse branch October 1, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@je-cook je-cook je-cook approved these changes

Assignees

@je-cook je-cook

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clmould @codecov-commenter @je-cook