Repository navigation
Round public birthdays down to a 10,000-block estimate - #49
Merged
Merged
Conversation
Mainnet and testnet compact-block, tree-state, and transparent-history requests use that bin so the exact creation height is not sent. Regtest stays exact. A journal that already recorded an earlier transparent event keeps its old floor. A later rescan inside the same bin is rejected.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bec11c1a74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The upstream check rebuilds memory_store.rs from the pinned wallet-pir sources and this patch. The placeholder raise has to be part of that adaptation.
A publication shard can start before the 10,000-block estimate. An older event in that shard stays in the acquisition journal. The wallet applies history from the estimate forward. A spend with no in-scope receive still refuses a completed checkpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo test -p z-engine --features transparent-pir --lib -- coarse_birthday transparent_history saved_event_below parse_digits_or_datecargo test -p z-transparent-pir-v2 --lib -- genesis_placeholdernode --conditions=@z-stack/source --import tsx --test packages/core/test/core.test.ts packages/sdk/test/engine.test.ts