Repository navigation
Keep scanned sends mined and remove expired payments - #48
Merged
Merged
Conversation
Expiry was releasing that send when no note decrypted, so a mined payment showed as expired and its inputs became spendable again.
Confirmed and still-pending payments stay. A payment whose output another saved payment spends stays too. Hardware rollback still uses the broader unmined abandon.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6858bfa4c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Batch sync recorded the mined height before that receipt existed, so its history date stayed empty. Stamp inclusion after ingest and before expiry can release a send the wallet already tracked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
abandonExpiredremoves one expired, unmined activity row on the native bridge and in the browser engine. Confirmed payments, still-pending payments, and a payment whose output another saved payment spends stay. Hardware rollback still uses the broader unminedabandon.Test
cargo test -p z-engine --lib saved_send_in_a_scanned_block_stays_mined_at_expirycargo test -p z-engine --lib abandon_expired_removes_only_an_expired_unmined_sendcargo test -p z-engine --lib abandon_expired_keeps_pending_mined_and_spent_outputs