Repository navigation
Add CDN segment transport and targeted shared memo fallback - #47
Merged
Merged
Conversation
… when tx is absent
The CDN rebase left an unreferenced TransparentPirSnapshot on core and a second optional retryPendingSubmission on Wallet. WasmClient already exposes the required retry method.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b43e5b904f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A 200 that is short, torn, oversized, or stalled fell through as a usable segment or stayed unbounded. Those cases now fall back to the live range once. Pending memo heights come from historyQuery by txid so an older incomplete row is not dropped by the newest history page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebase the remaining
codex/shield-cancellationwork onto currentmain(a25cfa8). Cancellation (#35), shared-memo request bounds (#46), and saved-byte submit context were already onmain, so those commits are not replayed.retryPendingSubmissiononmainalready resubmits the Rust-owned receipt with{ txid }and keeps the original reservation on failure, so the olderpendingTxsretry is not added.What this adds:
sharedMemoswhen the transport has notxmethod. Enhance PIR still replaces public txid lookups. A cloud wallet withsharedMemosandenhanceand notxkeeps the shared-memo path.origin/codex/shield-cancellationstays at589191dso the live nwallet pin remains fetchable until that pin moves.Verification
cargo fmt --all -- --checkpnpm check:packagesCI
rustis the required check.