Repository navigation
Conversation
The cr-sqlite extension jobs (CR SQLite C Tests, CR SQLite Rust Tests,
Extensions Tests) build Rust bindings from the SQLite C headers with
bindgen (bindgen = "0.68.1" in sqlite-rs-embedded/sqlite3_capi), which
loads the runner's system libclang at build time to parse the headers.
On the current `ubuntu-latest` runner image, that libclang fails to
parse the SQLite headers and bindgen emits opaque placeholder structs
instead of the real definitions. The generated `sqlite3_api_routines`
ends up with a single `_address` field and the nested
`sqlite3_index_info_sqlite3_index_constraint` types are missing, so the
crr build fails with ~140 errors:
error[E0432]: unresolved import `crate::bindings::sqlite3_index_info_sqlite3_index_constraint`
error[E0609]: no field `bind_blob` on type `sqlite3_api_routines`
note: available fields are: `_address`
This is a runner-environment regression, not a code change: the crr
sources are unchanged and the bindings generate correctly on the
previous image. Pin these jobs to the known-good `ubuntu-22.04` image,
matching the native-build jobs in libsql-server-release.yml, so bindgen
sees a compatible libclang and parses the headers correctly again.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #2337, which fixes the same cr-sqlite bindgen failure durably: instead of pinning to the soon-to-be-retired ubuntu-22.04 image, #2337 installs libclang-dev on ubuntu-latest so bindgen can parse the SQLite headers (matching rust.yml / nemesis.yml). Closing this stopgap in favor of #2337. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Extensions Tests workflow jobs (
CR SQLite C Tests,CR SQLite Rust Tests) are failing onmainwith ~140 Rust compile errors when building the cr-sqlite extension (cd ext/crr && make loadable/cargo test --features=loadable_extension):Root cause
libsql-sqlite3/ext/crr/rs/sqlite-rs-embedded/sqlite3_capigenerates its Rust bindings from the SQLite C headers at build time withbindgen = "0.68.1". bindgen loads the runner's system libclang to parse the headers. On the currentubuntu-latestrunner image, that libclang fails to parse the SQLite headers and bindgen falls back to emitting opaque placeholder structs —sqlite3_api_routinescomes out with only an_addressfield and the nestedsqlite3_index_info_sqlite3_index_constraint*types are missing entirely, which is exactly what the_address-only error notes show.This is a runner-environment regression, not a code change: the crr sources are unchanged, and the bindings generate correctly on the previous image (verified locally — bindgen 0.68.1 produces the full
sqlite3_api_routinesand the correct nested-struct names, and the crate compiles clean).Fix
Pin the three Extensions Tests jobs from
ubuntu-latestto the known-good"ubuntu-22.04"image, so bindgen sees a compatible libclang and parses the SQLite headers correctly. This matches the native-build jobs already pinned to"ubuntu-22.04"inlibsql-server-release.yml. The change is scoped strictly to the threeruns-on:lines.Files changed
.github/workflows/extensions-test.yml—c-tests,rs-tests,extensions-testsjobs pinned toubuntu-22.04(3 lines).Verification
available fields are: _address) from the failing run logs and traced it to bindgen emitting opaque structs.sqlite3_capibuilds clean withbindgen = "0.68.1"and generates the correct bindings (sqlite3_api_routineswith all fields,sqlite3_index_info_sqlite3_index_constraintpresent).ubuntu-22.04restores a green build.🤖 Generated with Claude Code