Repository navigation
Give casbin_admin_template_update its own migration version - #295
Merged
Merged
Conversation
20261016120000 was used twice: baked_snapshot_server_type (2b9eb5f, in dev since #291 and applied on dev) and casbin_admin_template_update (adb1779). sqlx keys _sqlx_migrations by version, so every fresh database failed with a duplicate key on _sqlx_migrations_pkey and the integration tests could not start the test app; a database that already applied one of them refuses the other at boot. casbin_admin_template_update moves to 20261016191200 (its commit time). It only inserts Casbin rules with ON CONFLICT DO NOTHING, so applying it under the new version is safe wherever it already ran. Regression test (red on dev): migration_boot_contract every_migration_version_is_used_once. migration_boot_contract 11 passed; admin_jwt, admin_notifications_bell, agent_command_flow (failing in CI) 21 passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012TKZy6f5shPzM9WLdswH6f
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
20261016120000was used by two migrations:baked_snapshot_server_type(#291, already applied on dev) andcasbin_admin_template_update(adb1779). sqlx keys_sqlx_migrationsby version, so:duplicate key value violates unique constraint "_sqlx_migrations_pkey", and the integration tests cannot start the test app (CI of every PR to dev, e.g. Quick Deploy: metered Managed server billing, no plan gate #294);casbin_admin_template_updatemoves to20261016191200. It only inserts Casbin rules withON CONFLICT DO NOTHING, so it is safe to apply again under the new version.Regression test:
migration_boot_contract::every_migration_version_is_used_once. It fails on dev and passes after the rename. The tests that failed in CI (admin_jwt,admin_notifications_bell,agent_command_flow) pass: 21 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_012TKZy6f5shPzM9WLdswH6f