docs: add AGENTS.md and reorganize project documentation - #6871
SeriousCoding789 wants to merge 20 commits into
Conversation
|
Two issues and one optional naming nit as below, please consider whether modifications are required.:
|
very good suggestion, will fix all. |
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Note the build fails fast on a JDK/arch mismatch - Scope the lint helper comment to framework main - Fix the generated-protobuf source path (core/, api/ subdirs) - Add the platform module (arch-specific source sets) to the layout - List both plugins jars (Toolkit, ArchiveManifest)
# Conflicts: # start.sh # start.sh.simple
0ca52e5 to
6266117
Compare
|
|
||
| ## Commit Convention | ||
|
|
||
| `type(scope): description` (Conventional Commits), 10–72 chars, no trailing period. |
There was a problem hiding this comment.
[SHOULD] Suggest keeping this section consistent with the content and requirements in CONTRIBUTING.md (for example, the lower-case description rule and the full scope list).
There was a problem hiding this comment.
Agreed. Rather than restating the rules and risking drift, I've cut the section down to a pointer at CONTRIBUTING.md#commit-messages, keeping only the note that .github/workflows/pr-check.yml is what validates PR titles and descriptions. CONTRIBUTING.md stays the single source.
| The java-tron project comes with several runnable artifacts and helper scripts found in the project root and build directories. | ||
| The java-tron project comes with several runnable artifacts found in the build directories. | ||
|
|
||
| | Artifact/Script | Description | |
There was a problem hiding this comment.
[SHOULD] The start.sh/start.sh.simple rows were removed, so no script is left in this table:
| | Artifact/Script | Description | | |
| | Artifact | Description | |
|
|
||
| **Actuator:** | ||
| - New actuators are registered automatically: place the class in the `org.tron.core.actuator` package, extend `AbstractActuator`, and pass the `ContractType` to `super(...)` from a no-arg constructor. `TransactionRegister.registerActuator()` discovers it by reflection at startup — there is no manual registration step. | ||
| - Charge fees before `execute()`. |
There was a problem hiding this comment.
[DISCUSS] Could you clarify what "before execute()" refers to here? As far as I can see, an actuator's own fee is charged inside execute().
| ``` | ||
|
|
||
| - Main entry point: `org.tron.program.FullNode`. | ||
| - Tests run in parallel locally, serially in CI (detected via the `CI` env var); the test-retry plugin retries up to 5 times. |
There was a problem hiding this comment.
[SHOULD] Tests also run in parallel in CI: framework/build.gradle sets maxParallelForks without checking the CI env var
What does this PR do?
AGENTS.md— a build/test/architecture guide for AI coding assistants and new contributors, covering the pre-commit checklist that mirrors the CI gates, the module dependency rules, and the invariants that must not be broken.docs/with consistent kebab-case names; marks two 2022-era protocol copies as superseded.start.sh,start.sh.simple,shell.md) — they are no longer maintained; node deployment is covered by the Docker image and is handed over totron-deployment..codeclimate.yml,sonar-project.properties, stale Sonar entries in the dependency verification metadata) and the.dockerignorefile.Why are these changes required?
java.lang.Mathprohibition, thereference.confschema and comment checks, dependency verification) were undocumented, so a contributor could only discover them by failing a build..codeclimate.ymlandsonar-project.propertiesare no longer used by CI.This PR has been tested by:
AGENTS.mdagainst the build configuration and sources, including running each command in the pre-commit checklist; confirmed all moved paths and cross-document links resolveFollow up
None.
Extra details