Run CI on Node 26 and name what each version is for - #689
Merged
Merged
Conversation
Node 26 is the newest release, so run the suite on it. Job names listed bare versions, which left the reader to work out which one was Ruby, Rails or ember-cli. They now name each, as in `build (Ruby 4.0, Rails 8.1, ember-cli 7.0.0, npm)`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI installs Node 22, while Node 26 is the newest release.
Job names list bare versions, such as
build (3.4, 8.1, 5.12.0, npm), which leaves the reader to work out which one is Ruby, Rails or ember-cli.What
26.xinstead of22.xbuild (Ruby 3.4, Rails 8.1, ember-cli 5.12.0, npm)The matrix itself is unchanged: the Vite-based blueprint (
7.0.0) runs on every Ruby and Rails combination, and the classic blueprints (5.12.0,6.7.2) and the other package managers run on Ruby 3.4 with Rails 8.1.Compatibility
Job names change, so any required status check that names a job has to be updated to the new name.