Skip to content

Update requirement for traderinteractive/util-http - #68

Merged
chadicus merged 6 commits into
traderinteractive:masterfrom
chadicus:master
Oct 1, 2026
Merged

chadicus merged 6 commits into
traderinteractive:masterfrom
chadicus:master

Conversation

@chadicus

@chadicus chadicus commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Updates requirement for traderinteractive/util-http
  • Add PHP 8.4 and 8.5 to the build matrix
  • Remove TravisCI integration
  • Remove Scrutinizer integration
  • Remove Coveralls integration
  • Update .gitgnore file

Checklist

  • [ ] Pull request contains a clear definition of changes
  • [ ] Tests (either unit, integration, or acceptance) written and passing
  • [ ] Relevant documentation produced and/or updated

@upwind-code-us

upwind-code-us Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Upwind Upwind Code Scan - ✅ Passed

0 newly introduced vulnerabilities · 0 resolved · 0 total in this PR vs master

View full analysis in Upwind Console

Scan completed in 14s

Scan history (2 scans)
Commit Scanned at New Resolved Net
49cf241 2026-10-01 13:45 UTC 0 0 0
5f5ab44 < 2026-10-01 13:48 UTC 0 0 0

Last scanned: 5f5ab44 · 2026-10-01 13:48 UTC

@upwind-code-us

upwind-code-us Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Upwind Upwind IaC Scan - ✅ Passed

0 misconfigurations detected

No default-branch baseline yet — showing all findings.

View full analysis in Upwind Console →

Scan completed in 21s

Scan history (2 scans)
Commit Scanned at New Resolved Net
49cf241 2026-10-01 13:44 UTC 0 0 0
5f5ab44 < 2026-10-01 13:48 UTC 0 0 0

Last scanned: 5f5ab44 · 2026-10-01 13:48 UTC

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 1bd21d23-5a09-4ef3-8ec9-9beace0e8179

📥 Commits

Reviewing files that changed from the base of the PR and between 6ca6861 and 5f5ab44.

📒 Files selected for processing (6)
  • .coveralls.yml
  • .github/workflows/php.yml
  • .gitignore
  • .scrutinizer.yml
  • .travis.yml
  • composer.json
💤 Files with no reviewable changes (3)
  • .scrutinizer.yml
  • .coveralls.yml
  • .travis.yml

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📜 Recent review details
🧰 Additional context used
🪛 zizmor (1.30.1)
.github/workflows/php.yml

[warning] 10-30: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)

🔇 Additional comments (3)
.github/workflows/php.yml (1)

14-14: LGTM!

.gitignore (1)

4-4: LGTM!

Also applies to: 7-8

composer.json (1)

30-30: LGTM!


Summary by CodeRabbit

  • Tests
    • Automated PHP compatibility checks now include PHP 8.4 and 8.5, in addition to the previously tested versions.
  • Chores
    • Updated the supported version range for an HTTP utility package.
    • Removed configuration for legacy build, code quality, and coverage reporting services.

Walkthrough

The PHP workflow adds PHP 8.4 and 8.5 to its test matrix. The pull request removes Travis CI, Coveralls, and Scrutinizer configuration, updates .gitignore, and raises the traderinteractive/util-http Composer constraint.

Changes

PHP tooling and dependency updates

Layer / File(s) Summary
PHP test matrix and CI configuration
.github/workflows/php.yml, .travis.yml, .coveralls.yml, .scrutinizer.yml, .gitignore
The workflow matrix adds PHP 8.4 and 8.5. The Travis CI, Coveralls, and Scrutinizer configuration files are removed. .gitignore adds dotfile rules with exceptions for /.github/ and .gitattributes.
Composer dependency constraint
composer.json
The traderinteractive/util-http version constraint changes from ^4.0 to ^4.0.1.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: chrisryan

Merge Risk: ⚪ Minimal · up to 5f5ab

The changes show no established build or dependency failure. PHPUnit compatibility on PHP 8.5 remains unverified, but no failing behavior was demonstrated.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the dependency requirement update, which is a real change in the pull request.
Description check ✅ Passed The description accurately summarizes the dependency update, PHP version additions, CI integration removals, and .gitignore changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@chadicus
chadicus marked this pull request as ready for review October 1, 2026 13:50
@chadicus
chadicus requested a review from a team as a code owner October 1, 2026 13:50
@chadicus
chadicus merged commit 852f12a into traderinteractive:master Oct 1, 2026
11 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants