feat: workspace.yml rename + first-boot-only goal (ADR-386-amendment-2) - #13
Merged
Merged
Conversation
Rename (pre-publish surface freeze): - .adlc/workspace-profile.yml → .adlc/workspace.yml; ADLC_WORKSPACE_PROFILE → ADLC_WORKSPACE_FILE; fixture team-directives-profile.yml → team-directives-workspace.yml; internal identifiers follow (WORKSPACE_FILE, loadWorkspaceFile, runWorkspaceCommand). Resolution order unchanged. First-boot-only goal (AX-faithful correction of the removal in 41900f0): - profile goal: field restored, gated on assembly: runs only when this setup performed ≥1 git clone or created ≥1 dir (changed-flag from the same existsSync decisions the idempotent steps use — no tracking file). - init/skills/commands never count (init always runs when declared). - re-runs converge and skip the goal silently; handoff hint shown exactly when the goal didn't run. Execution via the single agent-run primitive. Tests: 179 unit (goal appears/skips dry-run, real changed-flag boundary); e2e-profiles adds first-boot goal assert + full re-run block (goal skipped, no LLM, exit 0) + post-setup direct agent run; e2e-workspace path rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #12. Two changes, one commit (
f981431), drafted as ADR-386-amendment-2 (parent repo drafts):1. Rename: workspace-profile.yml → workspace.yml
"Profile" is residue from the abandoned spec-kit-style bundle/catalog design — no catalog, no registry, one declarative file per workspace. The file is the workspace definition, matching the
workspacecommand tree and/workspaceskill namespace. Free now (workspace tree unpublished — npm latest 1.0.2); breaking after 2.0.0 ships..adlc/workspace-profile.yml→.adlc/workspace.ymlADLC_WORKSPACE_PROFILEenv →ADLC_WORKSPACE_FILEteam-directives-profile.yml→team-directives-workspace.ymlWORKSPACE_FILE,loadWorkspaceFile,runWorkspaceCommand2. First-boot-only goal (AX-faithful correction)
#12 removed the profile
goal:field citing the "AX binding model" — that misread AX, which keeps a goal on the workspace binding, handed to an agent on first boot. This restores the field gated on assembly:changedflag = ≥1 git clone performed OR ≥1 dir created this run (dry-run predicts from the sameexistsSyncchecks)cmdAgentRunprimitive; handoff hint shown exactly when the goal didn't runTesting
e2e-workspace.sh— 20 assertions green (path rename)e2e-profiles.sh— 27 assertions green incl. new blocks: first-boot goal executes (E2E-GOAL-OK), re-run skips goal (skip line, no agent output, exit 0), post-setup directagent run0581a0b): rename mirror, e2e-container green with renamed log lineRelated
🤖 Generated with opencode