Fix possible fix(deps): 18 vulnerable dependencies in go.mod - #11
Open
begininvoke wants to merge 1 commit into
Open
Fix possible fix(deps): 18 vulnerable dependencies in go.mod#11begininvoke wants to merge 1 commit into
begininvoke wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing a fix for something flagged in
go.mod. It is around line 1.CRITICAL vulnerability (CVE-2026-56854) in golang.org/x/crypto v0.51.0, affecting the SSH server implementation. The 'source-address' critical option set in Permissions by authentication callbacks (PasswordCallback, KeyboardInteractiveCallback, NoClientAuthCallback, and GSSAPIWithMICConfig.AllowLogin) was silently ignored — it was only enforced for the PublicKeyCallback and VerifiedPublicKeyCallback paths (extending the incomplete fix for CVE-2026-46595). Impact: a client authenticating via password, keyboard-interactive, no-auth, or GSSAPI can connect from arbitrary, unauthorized IP addresses, bypassing source-IP restrictions the application intended to enforce. This is a remote authorization/access-control bypass (CWE-284) that can expose SSH servers reachable only from trusted hosts. Risk level: CRITICAL — remote bypass of a security control with no user interaction required; valid credentials are the only prerequisite. Remediation: upgrade to golang.org/x/crypto v0.55.0, where the source-address check is applied to Permissions returned by ALL authentication callbacks. As defense in depth, also consider enforcing IP allowlists at the network/ingress layer rather than relying solely on the SSH critical option.
Updates go.mod to fix critical CVE advisories by upgrading vulnerable dependencies to their fixed versions.
For reference: rule
CVE-2026-56854. Rated critical.I may well be missing context here — if the current code is deliberate, feel free to close this.
Found with automated scanning (RedGem) and reviewed before opening. If it is not useful, closing it is completely fine.