Auto: sync API from tigera/calico-private [release-calient-v3.23] - #326
Merged
marvin-tigera merged 1 commit intoOct 1, 2026
Merged
Conversation
marvin-tigera
approved these changes
Oct 1, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The CRD does not enforce the documented incompatibility between non-Auto modes and peerSelector.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds BGP peer connection initiation mode support across the API and generated artifacts.
Changes:
- Adds
Auto,Active, andPassiveconnection modes. - Updates apply configuration, OpenAPI, and CRD schemas.
| File | Description |
|---|---|
pkg/apis/projectcalico/v3/bgppeer.go |
Defines the new connection mode API. |
pkg/client/applyconfiguration_generated/projectcalico/v3/bgppeerspec.go |
Adds apply-configuration support. |
pkg/openapi/generated.openapi.go |
Exposes the field in OpenAPI. |
config/crd/projectcalico.org_bgppeers.yaml |
Adds its CRD schema and default. |
Files not reviewed (1)
- pkg/client/applyconfiguration_generated/projectcalico/v3/bgppeerspec.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+213
to
+214
| // +kubebuilder:validation:Enum=Auto;Active;Passive | ||
| ConnectionMode BGPPeerConnectionMode `json:"connectionMode,omitempty" validate:"omitempty,bgpPeerConnectionMode"` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of API files from
tigera/calico-privaterelease-calient-v3.23branch into this repo via
make -f Makefile.local update.Triggered by scheduled workflow.