Fix R-CMD-check CI on oldrel-4 (xgboost needs R >= 4.3.0) - #282
Merged
Merged
Conversation
xgboost now requires R >= 4.3.0, so pak can't resolve dependencies on the oldrel-4 CI legs (R 4.2), failing the whole job before any checks run. Use pak's ignore-before-r syntax to skip installing xgboost there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oldrel-4legs of R-CMD-check (ubuntu and windows, running R 4.2) have been failing becausexgboost(aSuggestsdependency) now requires R >= 4.3.0, sopak::lockfile_create()cannot resolve dependencies and the job fails before any tests run (see failure on Addstep_adjust_linear()for linear adjustment #281:Could not solve package dependencies: * xgboost: Needs R >= 4.3.0).?ignore-before-rremote spec (documented in r-lib/actions/setup-r-dependencies) to skip installingxgboostwhen running on R < 4.3.0, so those legs can install everything else and run the checks that don't rely onxgboost.Test plan
ubuntu-latest (oldrel-4)andwindows-latest (oldrel-4)