Repository navigation
Add README banners for every sample, a skill to render them, and switch the samples to npm - #12
Merged
Merged
Conversation
brionmario
force-pushed
the
sample-banners
branch
3 times, most recently
from
October 21, 2026 11:56
aaa4fb1 to
f6710b8
Compare
Also drops the Open in StackBlitz buttons from the quickstart READMEs, since they don't work, and bumps vite in the B2B sample to 8.3.4. Signed-off-by: Brion <info@brionmario.com>
brionmario
force-pushed
the
sample-banners
branch
from
October 21, 2026 12:23
f6710b8 to
ea1fa80
Compare
Replaces each sample's pnpm lockfile and workspace settings with package-lock.json, overrides and allowScripts, switches the PR builder to npm ci with an allow-list for accepted advisories, commits package-lock.json on release, and points the READMEs at npm. Also bumps React to 19.2.9 in the B2B and account samples to meet react-router's peer range, which npm enforces. Signed-off-by: Brion <info@brionmario.com>
DonOmalVindula
approved these changes
Oct 22, 2026
5 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Gives every sample README a banner in the ThunderID repo banner style, hosts the banners in this repository, and adds an agent skill so new samples get one the same way.
Approach
.agent/skills/sample-banner/holds the banner design (template/banner.css), the ThunderID mark and other shared SVGs, the technology logos with their sources (assets/logos/logos.json), and one entry per banner inbanners.json.scripts/render.cjsbuilds each banner and screenshots it with Playwright at 2x with a transparent background, giving 2000 by 840 PNGs in.github/assets/banners/. It has no dependencies in the repo; the skill gives thenpxcommand.raw.githubusercontent.comURL so it also renders inside the release zips. The root README banner moves from the thunderid repo to.github/assets/banners/samples.png.AGENTS.mddescribes the repo layout and routes any new sample or banner change to the skill.CLAUDE.mdloadsAGENTS.md, and.claude/skillslinks to.agent/skills.npm instead of pnpm (second commit)
package-lock.json. The pnpm lockfiles andpnpm-workspace.yamlfiles are gone; their settings move tooverrides(the postcss pin in nextjs and better-auth-nextjs) andallowScriptsinpackage.json.npm ciand caches throughsetup-node. npm audit has no ignore list, so the audit step checks high and critical advisories againstAUDIT_ALLOWED_GHSAS, the same two nuxt advisories that pnpm ignored and that Dependency Review already allows.package-lock.json, sincenpm versionbumps it.npm installandnpm run dev. The nextjs and nuxt READMEs gain the install step they were missing.b2b/manageandself-care/account.react-router@8.3.0needs>=19.2.7, which pnpm only warned about and npm refuses.AGENTS.mdtells agents to use npm for samples, and to go along with pnpm or yarn only when the developer insists, flagging the CI change that needs.Every sample was installed with
npm ci, audited, format-checked, linted and built locally.The banner URLs point at
main, so they render once this merges. The previews above use the branch.Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks