Skip to content

feat(theme): page redesign and dark mode for every page - #545

Open
Clupai8o0 wants to merge 2 commits into
thoth-tech:11.0.xfrom
ontrack-features-t2-2026:upstream-pr/redesign
Open

Clupai8o0 wants to merge 2 commits into
thoth-tech:11.0.xfrom
ontrack-features-t2-2026:upstream-pr/redesign

Conversation

@Clupai8o0

@Clupai8o0 Clupai8o0 commented Sep 27, 2026 •

Copy link
Copy Markdown

What this is

This is the dark mode page redesign for the student and staff pages. Every page now uses the same design in light and dark: token colours, cards with even spacing, page headers with their actions on the right, and real loading, empty and error states. Pages added in T2, like Course Flow, Unit Hub and student onboarding, are themed for dark mode too.

It was first opened on our team org as ontrack-features-t2-2026#192, where it got changes requested and was never approved. It was then relanded on current 11.0.x as ontrack-features-t2-2026#280 and merged into our org 11.0.x at 192078b93.

What is in it

How this set of PRs works

This is one of 24 PRs from the Thoth Tech T2 2026 Features team (9 api, 14 web, 1 deploy), one per feature per repo. Each one carries that feature's files, taken from our team org's 11.0.x branch, and applied straight onto thoth-tech 11.0.x. Every file is in exactly one PR. Some files are shared between features, so a PR on its own may not build. The demo PR in each repo (api #127, web #544) is imported by earlier PRs too, so it has to go in with the rest, not be dropped. Merged in the order below, the set equals our org 11.0.x minus team docs, evidence files, org-only CI and dev setup files. No app code or tests are left out.

On 28 Sep 2026 the set was brought up to our org's latest merges (api ontrack-features-t2-2026/doubtfire-api#178, web ontrack-features-t2-2026#281 and ontrack-features-t2-2026#282, deploy ontrack-features-t2-2026/doubtfire-deploy#41). Most PRs got one more commit for that. Two web PRs are new, panels (#546) and celebrate (#547), for files that were in no PR before.

Merge order, api first, then web, then deploy. In web, panels goes before the pages that use it, and celebrate goes after a11y, whose confetti service it needs.

Built against

  • api: thoth-tech 11.0.x @ dc76a5a0e, taken from org 11.0.x @ a9589b302
  • web: thoth-tech 11.0.x @ 20d1f380c, taken from org 11.0.x @ 0b8a20344
  • deploy: thoth-tech 11.0.x @ 58905969e, taken from org 11.0.x @ 8e560f7e0

Testing

Checked on 28 Sep 2026 with all the branches merged together. This PR was not tested on its own, see above.

  • web: with all 14 web branches merged onto thoth-tech 11.0.x, npm run test:ci runs 2603 tests in 290 files, all passing, and npm run lint and ng build pass. The merged set's app code is the same as our org 11.0.x after fix(profile): save a changed summary email cadence ontrack-features-t2-2026/doubtfire-web#282, where CI passed test, lint (22) and build (22).
  • api: the full Minitest suite passes on the nine api PRs merged onto thoth-tech 11.0.x. 1799 tests, 20182 assertions, 0 failures, 0 errors, 0 skips. It ran through our CI on branch check/upstream-combined-28sep (run), and the database schema check and RuboCop pass there too. The set differs from our org 11.0.x only by the left-out docs, evidence, CI and dev setup files, none of them app code.
  • deploy: production/tests/validate_test.sh, verify_pwa_test.py, publish_release_test.py and nginx_upload_test.py pass. The production compose file loads with docker compose config against .env.production.example, and the development and .devcontainer ones load as they are.
  • I tested every page in light and dark by hand on a local stack, and again on this code at desktop, tablet and phone widths.

Contributors

Samridh Limbu, Maple Fox, Davie

Brings the dark mode page redesign (#280, which relands
#192)
onto thoth-tech 11.0.x. These are the redesign files that no other PR in the set carries.

Co-authored-by: Davie <W196n8y@gmail.com>
Co-authored-by: Maple Fox <s223932052@deakin.edu.au>
This was referenced Sep 27, 2026
Brings #281 and
#282 to the files this PR
already carries, so every file stays in exactly one PR. It carries the
submission, extension and portfolio dialog changes and the test clean up
that landed with them. The task spec now uses the shared AppInjector
stub, so it no longer breaks other specs in the same test worker.

Co-authored-by: Maple Fox <s223932052@deakin.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants