Repository navigation
fix(rdf): index object values of const, default and enum - #1
Merged
Merged
Conversation
A TD may give const, default or enum an object value, such as
{"type": 2}. The SPARQL index read that object as JSON-LD, took its
"type" key as an RDF type, and failed the whole TD. Such a value is now
stored as one JSON literal. Strings and numbers are unchanged.
A TD that still fails to convert is logged and skipped, instead of
failing every later sync and the server start.
Source: https://www.w3.org/TR/wot-thing-description11/#dataschema
Source: https://www.w3.org/TR/json-ld11/#json-literals
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: zasherif <zasherif@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A TD may give const, default or enum an object value, such as {"type": 2}. The SPARQL index read it as JSON-LD, took its "type" key as an RDF type, and failed the whole TD. Such a value is now stored as one JSON literal; strings and numbers are unchanged. A TD that still fails to convert is logged and skipped instead of failing every later sync.