Fix is_expired docstring for reference_time - #3009
Merged
jku merged 1 commit intoSep 1, 2026
Merged
Conversation
Signed-off-by: Sachith Reddy <sachith.24bcs10403@sst.scaler.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Signed.is_expired()docstring says thatreference_timeshould be a naive datetime, but passing a naive datetime raises:snapshot.is_expired(datetime(2026, 1, 1))
TypeError: can't compare offset-naive and offset-aware datetimes
self.expiresis timezone-aware, and the defaultdatetime.now(timezone.utc)is aware as well, soreference_timeneeds to be timezone-aware too.This PR only updates the docstring and does not change the behaviour.