Repository navigation
audio: iadk: implement KPB service - #11307
Draft
serhiy-katsyuba-intel wants to merge 3 commits into
Draft
serhiy-katsyuba-intel wants to merge 3 commits into
serhiy-katsyuba-intel wants to merge 3 commits into
Conversation
Declare KpbInterface and KpbInterfaceV2 for the KPB service so that IADK modules can use the SOF KPB module. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com> Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Add an independent KPB notifier option and use it to guard the notifier API. This allows notifier and AMS transport support to be enabled separately or together. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
Implement the KPB service, which provides KpbInterface and KpbInterfaceV2 interfaces so that IADK modules can use the SOF KPB module. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com> Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
serhiy-katsyuba-intel
requested review from
dbaluta,
fkwasowi,
iganakov,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
ranj063
as code owners
October 14, 2026 12:26
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The public token is incomplete, and the userspace bridge directly invokes an asynchronous kernel notifier without a validated boundary or reliable registration result.
6 open findings
What changed in this PR
Adds IADK KPB service interfaces and connects them to SOF’s KPB component.
Changes:
- Implements KPB v1/v2 interfaces and client operations.
- Exposes interfaces through the native system service.
- Adds notifier transport, unregister handling, and build configuration.
| File | Description |
|---|---|
src/include/sof/audio/module_adapter/library/native_system_service.h |
Declares KPB interface providers. |
src/include/sof/audio/module_adapter/library/kpb_service.h |
Defines the C bridge API. |
src/include/sof/audio/module_adapter/iadk/kpb_interface.h |
Defines IADK KPB interfaces. |
src/audio/module_adapter/library/native_system_service.c |
Resolves versioned KPB interfaces. |
src/audio/module_adapter/library/kpb_service.cpp |
Implements C++ interface adapters. |
src/audio/module_adapter/library/kpb_service_bridge.c |
Bridges clients to KPB notifications. |
src/audio/module_adapter/Kconfig |
Enables notifier support for Intel modules. |
src/audio/module_adapter/CMakeLists.txt |
Builds KPB service sources. |
src/audio/kpb.c |
Generalizes notifier handling and unregisters clients. |
src/audio/Kconfig |
Adds the KPB notifier option. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+26
to
+29
| AdspErrorCode error = kpb_service_register_client( | ||
| current_history_depth, | ||
| max_history_depth, | ||
| output_pin, &client); |
Comment on lines
+47
to
+48
| notifier_event(client, NOTIFIER_ID_KPB_CLIENT_EVT, NOTIFIER_TARGET_CORE_ALL_MASK, | ||
| &client->event, sizeof(client->event)); |
Comment on lines
+47
to
+48
| notifier_event(client, NOTIFIER_ID_KPB_CLIENT_EVT, NOTIFIER_TARGET_CORE_ALL_MASK, | ||
| &client->event, sizeof(client->event)); |
| { | ||
| class ModuleHandle; | ||
|
|
||
| struct KpbToken; |
Comment on lines
+57
to
+59
| if (!client || output_pin >= KPB_MAX_NO_OF_CLIENTS || | ||
| current_history_depth > UINT32_MAX || max_history_depth > UINT32_MAX) | ||
| return ADSP_INVALID_PARAMETERS; |
Comment on lines
+74
to
+77
| kpb_service_send_event(new_client, KPB_EVENT_REGISTER_CLIENT); | ||
|
|
||
| *client = new_client; | ||
| return ADSP_NO_ERROR; |
serhiy-katsyuba-intel
marked this pull request as draft
October 14, 2026 12:43
lgirdwood
reviewed
Oct 14, 2026
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
LGTM, just minor questions. We can come back and use native zephyr messaging once we have working wov 1/2 merged if needed.
|
|
||
| #if CONFIG_KPB_NOTIFIER | ||
| /* Register KPB for notification *on the current core* */ | ||
| ret = notifier_register(dev, NULL, NOTIFIER_ID_KPB_CLIENT_EVT, kpb_event_handler); |
Member
There was a problem hiding this comment.
This is going away for a more Zephyr native approach, we can probably catch this as we update WOV. Btw commit message says AMS ?
| namespace intel_adsp | ||
| { | ||
|
|
||
| struct KpbToken { |
Member
There was a problem hiding this comment.
Can we doxygen all structs, types, classes etc ?
PR 11307: test resultsRun date: 2026-10-14 13:39 UTC Tested commit: cfbccb819609729971976755fa1f818ff4c6ab43
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the KPB service, which provides KpbInterface and KpbInterfaceV2 interfaces so that IADK modules can use the SOF KPB module.