Repository navigation
Conversation
tmleman
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
October 8, 2026 09:54
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly prevents uninitialized status data from being consumed and preserves legacy-path behavior.
0 open findings
What changed in this PR
Prevents failed DMA status queries from corrupting probe buffer accounting.
Changes:
- Checks
dma_get_status()before consuming status fields. - Uses signed formatting for negative error codes.
| File | Description |
|---|---|
src/probe/probe.c |
Safely handles DMA status failures in probe injection. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
On the Zephyr native driver path the dma_status structure was read into dma->dmapb.avail and free_bytes before the return code was tested, so a failing dma_get_status() propagated uninitialized stack data into the probe buffer accounting. Move the error check directly after each call and only consume the status on success. Also correct the error trace format specifier from %u to %d. Found by clang-analyzer-core.uninitialized.Assign. Assisted-by: Copilot:claude-opus-5 clang-tidy Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
PR 11285: test resultsRun date: 2026-10-08 18:10 UTC Tested commit: addab6589fe8d0b44ba1d7a88134c740d971eb47
|
tmleman
requested review from
abonislawski,
jsarha,
lyakh,
serhiy-katsyuba-intel,
softwarecki and
wjablon1
October 8, 2026 12:41
lgirdwood
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Zephyr native driver path the dma_status structure was read into dma->dmapb.avail and free_bytes before the return code was tested, so a failing dma_get_status() propagated uninitialized stack data into the probe buffer accounting.
Move the error check directly after each call and only consume the status on success. Also correct the error trace format specifier from %u to %d.
Found by clang-analyzer-core.uninitialized.Assign.
Assisted-by: Copilot:claude-opus-5 clang-tidy