Skip to content

module: mux: fix dead source check in demux_process #11284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmleman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

module: mux: fix dead source check in demux_process #11284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/audio/mux/mux.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,15 +245,12 @@ static int demux_process(struct processing_module *mod,

comp_dbg(dev, "entry");

if (sources == NULL && sources[0] == NULL) {
/* if there are no sources or sinks active, then there is nothing to do */
if (num_of_sources == 0 || num_of_sinks == 0) {

@lgirdwood lgirdwood Oct 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmocka being deprecated in favour of ztests so acceptable.

return 0;
}
source = sources[0];

/* if there are no sinks active, then there is nothing to do */
if (num_of_sinks == 0) {
return 0;
}
source = sources[0];

/* the same number of frames is distributed to every sink, so it is
* limited by both the source availability and every active sink's free
Expand Down
Loading