Repository navigation
Conversation
Setting the ctype to most logical choice was not correct. Python, both 3.12 and 3.14, have a 'feature' that a packed ctype struct forces layout to "ms". 3.12 did this silently, but 3.14 gives a warning if the layout is not explicitly set, and an error if its set to something else than "ms", in packed structs. Fixes: 2451522 ("tools: debug_stream: set explicit ctypes layout") Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
jsarha
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
October 8, 2026 09:05
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The three layout changes match ctypes packing requirements and preserve compatibility with the firmware record definitions.
0 open findings
What changed in this PR
Corrects packed structure layouts in the debug-stream decoder for Python 3.14 compatibility.
Changes:
- Sets
_layout_ = "ms"forCPUInfo,ThreadInfo, andTextMsg, matching ctypes packing requirements.
| File | Description |
|---|---|
| tools/debug_stream/debug_stream.py | Corrects explicit layouts for three packed ctypes structures. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
PR 11283: test resultsRun date: 2026-10-08 14:00 UTC Tested commit: babf26b4507a226bdfb9985ebf79f1c62eaac481
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the ctype to most logical choice was not correct. Python, both 3.12 and 3.14, have a 'feature' that a packed ctype struct forces layout to "ms". 3.12 did this silently, but 3.14 gives a warning if the layout is not explicitly set, and an error if its set to something else than "ms", in packed structs.
Fixes: 2451522 ("tools: debug_stream: set explicit ctypes layout")