Repository navigation
Conversation
tmleman
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
October 7, 2026 17:11
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused control-flow fix correctly eliminates the reported uninitialized read.
0 open findings
What changed in this PR
Prevents publishing uninitialized IPC4 base configuration values when attribute retrieval fails.
Changes:
- Return immediately after assigning neutral component metrics on failure.
| File | Description |
|---|---|
src/audio/component.c |
Prevents reading dev_cfg after failed initialization. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
PR 11280: test resultsRun date: 2026-10-07 17:38 UTC Tested commit: 7e6c9d26e3b5a8f295dec7f0551b0d9ce227a863
|
comp_update_ibs_obs_cpc() logged the comp_get_attribute() failure and set neutral values, but then fell through and immediately overwrote them from the uninitialized dev_cfg stack structure, publishing garbage ll_chunk_size, obs, ibs and cpc values to the component. Return right after setting the neutral values so dev_cfg is only read when comp_get_attribute() succeeded. Found by clang-analyzer-core.uninitialized.Assign. Assisted-by: Copilot:claude-opus-5 clang-tidy Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
tmleman
requested review from
abonislawski,
piotrhoppeintel,
softwarecki and
wjablon1
October 7, 2026 19:06
abonislawski
approved these changes
Oct 8, 2026
kv2019i
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comp_update_ibs_obs_cpc() logged the comp_get_attribute() failure and set neutral values, but then fell through and immediately overwrote them from the uninitialized dev_cfg stack structure, publishing garbage ll_chunk_size, obs, ibs and cpc values to the component.
Return right after setting the neutral values so dev_cfg is only read when comp_get_attribute() succeeded.
Found by clang-analyzer-core.uninitialized.Assign.
Assisted-by: Copilot:claude-opus-5 clang-tidy