Repository navigation
audio: mfcc: validate config blob size before use - #11270
Merged
Merged
Conversation
mfcc_prepare() only checked that the configuration blob was non-empty before mfcc_setup() and the processing code dereferenced it as a struct sof_mfcc_config, over-reading adjacent heap for a short blob. Require the blob to cover the config struct. Signed-off-by: Shrushti P K <shrusthi@labs.digiscrypt.com>
Shrusti-pk
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
October 5, 2026 16:18
Collaborator
|
Can one of the admins verify this patch?
|
kv2019i
approved these changes
Oct 8, 2026
kv2019i
left a comment
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @Shrusti-pk for the patch!
abonislawski
approved these changes
Oct 8, 2026
Member
|
CI triggered |
PR 11270: test resultsRun date: 2026-10-09 08:13 UTC Tested commit: ea883f1e4c42039b2213ab5375dee6e02b05f29b
|
lgirdwood
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mfcc_prepare uses the config blob without checking it is long enough:
Required the blob to cover the config struct, as drc_prepare does since d859e5d; the shipped mfcc blobs are all exactly 116 bytes so valid topologies are unaffected.