Repository navigation
feat: add historySerialization with default behaviour - #214
Open
TiagoCerqueira wants to merge 4 commits into
Open
TiagoCerqueira wants to merge 4 commits into
TiagoCerqueira wants to merge 4 commits into
Conversation
TiagoCerqueira
force-pushed
the
feat/BOTIV-9965-serialization-backend-message
branch
from
September 3, 2026 14:11
75bf6c2 to
2bd3061
Compare
Fabilin
reviewed
Sep 4, 2026
TiagoCerqueira
force-pushed
the
feat/BOTIV-9965-serialization-backend-message
branch
from
September 8, 2026 14:11
2bd3061 to
0f5f55e
Compare
Fabilin
reviewed
Sep 8, 2026
TiagoCerqueira
force-pushed
the
feat/BOTIV-9965-serialization-backend-message
branch
from
September 9, 2026 13:41
0f5f55e to
85a7ba1
Compare
Fabilin
approved these changes
Nov 12, 2026
Fabilin
requested changes
Nov 13, 2026
| // When the chat gets initialized for the first time, process optional referral|opening message | ||
| sseInitPromise.then(async () => { | ||
| const history = loadHistory(); | ||
| const history = await loadHistory(); |
Member
There was a problem hiding this comment.
On further testing, this change exacerbates a pre-existing race condition, where an established SSE connection can start receiving queued messages from the backend before the history loads, leading to some of the new messages appearing at the very top of the conversation (and thus being easily missed by the user).
suggested fix: switch to loading the history before establishing the SSE connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #213 by adding encryption support while allowing consumers to provide a custom encryption/decryption implementation, with the existing behaviour preserved by default.