Skip to content

Fix PHPStan level 0 failures on published Thelia - #19

Merged
anoziere merged 4 commits into
mainfrom
fix/ci-debt
Oct 18, 2026
Merged

anoziere merged 4 commits into
mainfrom
fix/ci-debt

Conversation

@anoziere

Copy link
Copy Markdown
Contributor

The PHPStan job reported 13 errors:

  • KeywordController and KeywordGroupController: getObjectFromEvent, getObjectLabel, getObjectId (and performAdditionalUpdateAction on the keyword controller) were empty stubs with a typed return, so creating a keyword or a group failed with a TypeError once the object was read back. They now return the object of the event, its title and its id.
  • The four creation and modification forms imported ExecutionContextInterface from a Symfony namespace that does not exist (Validator\ExecutionContextInterface instead of Validator\Context\ExecutionContextInterface).
  • The keyword and keyword_group loops ordered given_id on ContentTableMap, copied from the content loop and never imported. They now use the table map of their own table.

No Smarty template is left in the module. Version bumped to 4.0.1.

@anoziere
anoziere merged commit 3246f3f into main Oct 18, 2026
5 checks passed
@anoziere
anoziere deleted the fix/ci-debt branch October 18, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant