Repository navigation
Fix module CI on Thelia 3: services exclusion and PHPStan errors - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes what the shared module CI reported against the published Thelia:
configureServices()excluded translations throughTHELIA_MODULE_DIR, which does not point to the module when it lives inlocal/modules/. Symfony then failed on theI18nclasses and the module ran without services. The exclusion is now relative to the module directory.suggest):OrderAddressColissimoPickupPointQueryis now only used behindclass_exists()inLabelServiceandUpdateDeliveryAddressListener.GenerateLabelListener::generateLabel()typed its parameter with a class of the optional Picking module; it is typedobject, the listener is only subscribed when that module is present.ConnectionInterfaceparameters are explicit (deprecated in PHP 8.4).