Skip to content

Rotation matrix storage order documented backwards #296

Description

@trsxvz

docs/web/orthotropic-behaviours.md:75-77, and the same wording in the 1.2 release notes.

Finding. The documentation states that the rotation matrix has nine components stored in column-major format. The generated MFront code copies those nine values into a TFEL matrix whose policy is row-major, so component 3*i + j is the entry at row i and column j.

Effect. A user who fills the matrix as documented passes the transpose, which for a rotation is the inverse, so the change of frame is applied backwards with no error. Every example and test uses a symmetric matrix.

Fix. Document the row-major, C storage order explicitly.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions