Repository navigation
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ctrlc03
force-pushed
the
large/release-large
branch
from
November 20, 2026 09:48
72eeddb to
4904ab1
Compare
ctrlc03
force-pushed
the
large/sepolia-cutover-large
branch
from
November 20, 2026 09:48
6ae01bc to
fe5e972
Compare
ctrlc03
force-pushed
the
large/release-large
branch
from
November 20, 2026 17:21
4904ab1 to
7446f77
Compare
ctrlc03
force-pushed
the
large/sepolia-cutover-large
branch
from
November 20, 2026 17:22
fe5e972 to
c04989b
Compare
One Large node measured 1,213 s of DKG proving on secure-8192. Live Sepolia holds a 1,800 s window (this file said 1,200 s), which leaves little margin. Use the 7,200 s the example configuration uses.
…onfigured size The Sepolia configuration now lists committee size 3. `upgrade:v19` reads each configured size from the implementation that the batch replaces, and the live Sepolia Interfold reverts without data on size 3, because its `CommitteeSize` has three members. Read that revert as an unset size, so the batch sets it after the upgrade.
…mittee `upgrade:v19` applies the committee thresholds of the configuration but not its timeout windows. Live Sepolia holds a 1800 s DKG window, so the 7200 s of the configuration needs `setTimeoutConfig` in the Sepolia batch.
…fer from the configuration The cutover batch does not set the timeout windows, so a Sepolia batch without the manual setTimeoutConfig kept dkgWindow at 1800 s and validate, which resume runs first, still passed. Validation now compares getTimeoutConfig() with the configured windows. Live Mainnet already matches its configuration (21600, 604800, 21600).
…ase knows prepare treated any empty revert of committeeThresholds as unset. The read is now readCommitteeThreshold, which rethrows unless the size is one this release routes, and it is tested with Sepolia's empty revert, an unknown size and a transport failure. The Sepolia paragraph now names the upgrade:v19:validate and upgrade:v19:resume scripts, the 1,213 s hardware, that 7200 s applies to every Sepolia size, that the Sepolia batch raises no node release, and that Sepolia lacks 45 operators. The timeout test is named after the predicate it checks.
…tion lacks it readCommitteeThreshold accepted an empty revert for every size the chain routes, so a data-less revert on Minimum, Micro or Small would have queued a silent re-set. Only SIZES_ADDED_BY_RELEASE (Large) may read as unset; the test now shows an empty revert on size 0 is rethrown.
ctrlc03
force-pushed
the
large/sepolia-cutover-large
branch
from
November 21, 2026 15:26
c04989b to
386ed20
Compare
ctrlc03
force-pushed
the
large/release-large
branch
from
November 21, 2026 15:26
7446f77 to
424a24c
Compare
Collaborator
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Split from #2398 (Zara's work). Stacked on #2537 (
large/release-large); review that one first.Prepares live Sepolia for the Large committee that #2537 routes there.
sepolia-protocol.config.jsonraisesdkgWindowto 7200 s: one Large node measured 1,213 s ofDKG proving on secure-8192. Live Sepolia holds 1800 s (the file's earlier 1200 s was stale). The
value applies to every Sepolia E3: the worst-case committee setup, and CRISP's
earliestVotingStart(), become 8,316 s after the request.upgrade:v19now prepares a batch when the live implementation predates a configured committeesize (Sepolia, size 3): it treats the revert as an unset threshold instead of stopping.
upgrade:v19 validate, whichresumeruns first, comparesgetTimeoutConfig()with theconfigured windows and refuses while they differ, so Sepolia cannot resume on the old 1800 s
dkgWindowif the manualsetTimeoutConfigwas missed.docs/architecture/upgrades.mdstates the Sepolia cutover steps for Large.Verification
Static checks only; CI runs the tests.
(
node scripts/blueprint/check.mjsstill exits 1 on drift that predates this stack).tsc --noEmitran before the resume check; the check itself was not type-checked locally (no
node_modules), soCI's
tscand contract tests cover it.getTimeoutConfig: Sepolia(1800, 604800, 21600); Mainnet(21600, 604800, 21600), equal to its configuration, so the new check does not block Mainnet.V19Cutover.spec.tspins that the shipped Sepolia configuration rejects the live 1800 s window.Compatibility
setCommitteeThresholds(3, [34, 45])(prepared byupgrade:v19) andsetTimeoutConfig(added by hand); seedocs/architecture/upgrades.md.validatenow also compares Mainnet's live windows, which equal itsconfiguration, so Mainnet passes the new check.
Follow-ups (not in this stack)
nodeRelease.ts,resumeVrfSortition.ts) now need 45 activeoperators.
Update 2026-11-21: rebased onto main (#2524–#2530) and Fable review fixes
34bbe1544,57ffdb0fe:prepare's empty-revert handling isreadCommitteeThreshold, which reads only Large (the size this release adds) as unset and rethrows otherwise; tested with Sepolia's empty revert, size 0 and a transport failure.386ed2085and earlier docs: script names, the 1,213 s hardware (16 cores / 32 threads), 7200 s for every Sepolia size, no node-release raise on Sepolia, too few Sepolia operators for Large yet, and the persistedLargevariant with its rollback.