Repository navigation
feat(nexus): paginate the Nexus Links tables (FE-1106) - #4041
Open
rossedfort wants to merge 1 commit into
Open
rossedfort wants to merge 1 commit into
rossedfort wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
KATIETOLER
approved these changes
Oct 15, 2026
KATIETOLER
left a comment
Contributor
There was a problem hiding this comment.
All the testing flows worked well, looks good to me!
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
The CHASM migration raises the number of Nexus links a workflow can have from 30 to 2000. The Nexus Links tab drew both tables as plain
Tables, so all of those rows would render at once. Both tables now use the client-sidePaginatedtable already used on the deployment and Nexus endpoint pages. Link order is unchanged, and page sizes stay at the standard 100/250/500/1000, so anything up to 100 links still fits on one page.Paginatedkept its state in fixedpageandper-pageURL params. Two of them on one page would read the same params, so paging Outbound would also page Inbound, and both page-size selects would get the same DOM id.Paginatednow takes optionalpageParameterandperPageParameterprops. They default to the existing keys, so current pages behave as before. The Nexus Links tables useinbound-page/inbound-per-pageandoutbound-page/outbound-per-page.Also fixed: both tables' screen-reader captions said "Workers" (a copy-paste leftover). The captions and the Inbound/Outbound headings now come from i18n strings.
Testing 🧪
How was this tested 👻
Added
paginated.svelte.test.tscases for a custom page param (?inbound-page=3&page=1renders page 3) and a custom page-size param.Steps for others to test: 🚶🏽♂️🚶🏽♀️
?outbound-page=99and confirm it jumps back to the last page.Issue(s) closed
FE-1106