Repository navigation
fix(docker): bump dockerize to v0.15.2 - #4040
Closed
erikryanmoore wants to merge 1 commit into
Closed
erikryanmoore wants to merge 1 commit into
erikryanmoore wants to merge 1 commit into
Conversation
dockerize v0.10.1 pins golang.org/x/crypto v0.47.0 and golang.org/x/net v0.49.0, so the UI image carries 16 high vulnerabilities in /usr/local/bin/dockerize even though ui-server itself is clean. v0.15.2 moves to x/crypto v0.57.0 and drops x/net, but its go directive needs Go 1.27, so only the dockerize-builder stage moves to golang:1.27.2-alpine3.23. The server-builder stage is unchanged.
|
@erikryanmoore is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
server/Dockerfileinstalls dockerize v0.10.1. That release pinsgolang.org/x/cryptov0.47.0 andgolang.org/x/netv0.49.0. Ontemporalio/ui:2.56.0, Trivy 0.74.0 reports 16 high vulnerabilities with a fixed version in/usr/local/bin/dockerize. They are the only critical or high findings with a fix in the image:ui-serverand the Alpine layer are clean.dockerize v0.15.2 uses
golang.org/x/cryptov0.57.0 and no longer depends ongolang.org/x/net. Itsgodirective is 1.27.2, and the official golang images setGOTOOLCHAIN=local, so only thedockerize-builderstage moves togolang:1.27.2-alpine3.23. Theserver-builderand runtime stages are unchanged.server/docker/README.mdsays dockerize templating is deprecated. If you prefer to remove dockerize now (#1703), that also clears these findings. This PR is the smallest change that keeps the legacy config-template path working.Vulnerabilities in
/usr/local/bin/dockerizethat this removes:golang.org/x/cryptov0.47.0: CVE-2026-39828, CVE-2026-39829, CVE-2026-39830, CVE-2026-39831, CVE-2026-39832, CVE-2026-39835, CVE-2026-42508, CVE-2026-46595, CVE-2026-46597, CVE-2026-56854golang.org/x/netv0.49.0: CVE-2026-25681, CVE-2026-27136, CVE-2026-33814, CVE-2026-39821, CVE-2026-46600, CVE-2026-78669Testing
How was this tested
I built the new
dockerize-builderstage for linux/amd64 and copied its binary over/usr/local/bin/dockerizeintemporalio/ui:2.56.0. Then:trivy image --scanners vuln --ignore-unfixed --severity CRITICAL,HIGH --exit-code 1 <image>exits 0. On stocktemporalio/ui:2.56.0it exits 1 with the 16 findings above.dockerize -templaterenders a{{ .Env.TEMPORAL_ADDRESS }}template with the value from the environment. A Sprig-style{{ env "X" | default "y" }}template renders the same output with v0.10.1 and v0.15.2.I did not build the full image from a bare checkout, because
server-builderembedsserver/ui/assetsfrom the frontend build.Steps for others to test:
Build the image as your release pipeline does, then run
trivy image --scanners vuln --ignore-unfixed --severity CRITICAL,HIGH --exit-code 1 <image>anddocker run --rm --entrypoint dockerize <image> --help.Checklists
Issue(s) closed
Addresses the dockerize findings in #3923.
Docs
Any docs updates needed?
No.