Repository navigation
Conversation
…lient WorkflowClient::newWorkflowStub() now merges the handler's #[MethodRetry] into WorkflowOptions, as child workflow stubs already do. User-set retry fields keep precedence. #[CronSchedule] stays ignored on client starts. Behavior change: a workflow whose handler has #[MethodRetry] now gets a RetryPolicy when started from the client.
rela589n
force-pushed
the
feat/client-method-retry
branch
from
October 28, 2026 12:09
e9e8109 to
088c405
Compare
|
|
1 similar comment
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#[MethodRetry]on workflow handler work only for child workflows. Start same workflow viaWorkflowClient::newWorkflowStub(): attribute silently dropped, noRetryPolicysent.WorkflowOptions::mergeWith()existed but nothing insrc/called it.Fix
newWorkflowStub()merge handler's#[MethodRetry]intoWorkflowOptions, same asChildWorkflowProxy. User-set retry fields still win.#[CronSchedule]stay ignored on client starts on purpose: inheriting cron from class too risky. Docblock now say so.Behavior change
Workflow with
#[MethodRetry]on handler now retries when started from client.Proof
WorkflowClientMethodRetryTestCase: retry policy from attribute, user field wins, cron empty. Fails without fix.🤖 Generated with Claude Code