Skip to content

Add pull request template - #531

Merged
stephanos merged 8 commits into
mainfrom
stephanos/pr-template
Oct 27, 2026
Merged

stephanos merged 8 commits into
mainfrom
stephanos/pr-template

Conversation

@stephanos

@stephanos stephanos commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

What changed?

Adds a pull request template, based on temporalio/temporal's, with a shorter testing checklist that fits omes.

Potential risks

None, it's documentation only.

stephanos and others added 7 commits October 27, 2026 11:24
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@stephanos
stephanos marked this pull request as ready for review October 27, 2026 18:45
@stephanos
stephanos requested review from a team as code owners October 27, 2026 18:45

@THardy98 THardy98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if it's worth adding a section for "sensitive change" for anything that may cause changes to performance of an existing workload

@stephanos

Copy link
Copy Markdown
Collaborator Author

@THardy98 wouldn't that be covered by "Potential Risks"? And is that sth that you think is non-obvious sometimes?

@THardy98

Copy link
Copy Markdown
Contributor

@THardy98 wouldn't that be covered by "Potential Risks"? And is that sth that you think is non-obvious sometimes?

Moreso it's just at the bottom so it gets less notice I think.
But I don't really have a strong opinion - i think it's fine in any case

@stephanos
stephanos enabled auto-merge (squash) October 27, 2026 22:22
@stephanos
stephanos merged commit 2f5e4fc into main Oct 27, 2026
53 checks passed
@stephanos
stephanos deleted the stephanos/pr-template branch October 27, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants