Repository navigation
Conversation
lilydoar
force-pushed
the
lilydoar/throughput-original-start
branch
from
October 26, 2026 21:12
724e0d9 to
95cf374
Compare
lilydoar
force-pushed
the
lilydoar/throughput-original-start
branch
2 times, most recently
from
October 27, 2026 20:55
7f8b2e5 to
6cfcd89
Compare
lilydoar
force-pushed
the
lilydoar/throughput-original-start
branch
from
October 27, 2026 20:58
6cfcd89 to
f0aac55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Freeze the original throughput request and ordinary-versus-Update-with-Start choice across retries of a fresh strict iteration. Ordinary starts attach only to the history-verified original run; acknowledged run/update handles are retained, and failed closed executions are not replaced.
Review: As a single unit in stack order.
Why
Reconstructing actions and start mode on every iteration attempt can collide with a workflow whose start succeeded but whose response was lost. Reusing only its workflow ID can also redirect an update to a different execution after ID reuse.
Details worth reviewing
Merge after #523, including #518's SDK prerequisite. Existing resumed/IgnoreAlreadyStarted paths retain their legacy behavior; the new identity is in-process state and does not add durable recovery across activity/process reconstruction.
An Update-with-Start error before any returned run handle remains a strict failure with no replay. The public SDK cannot bind a reconstructed Update-with-Start to a known RunID; a stable UpdateID alone does not solve that uncertainty. This is scoped start safety, not complete FI qualification.