Repository navigation
Ensure .NET harness workers stop after each feature - #937
Merged
Merged
Conversation
Stop workers when features return no workflow handle or fail during execution or checks. Preserve the original feature failure when worker cleanup also fails. Add nine regression cases and run the harness test project in CI.
dplyukhin
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Always call
StopWorker()when a feature finishes, including when it returnsnullor throws. Preserve the original feature failure if cleanup also throws.Why?
Features like #934 should be able to stop their worker automatically without having to return a workflow handle.
Checklist
Closes Ensure .NET harness stops workers when features return null or throw #936
How was this tested:
Added nine regression cases covering null returns, execution and check failures, explicit worker stop/restart, and cleanup failures. Updated CI to run them.
Any docs updates needed?