Skip to content

[CLDAPP-423] Add Encryption Validation - #113

Merged
khisakuni merged 8 commits into
mainfrom
daehan/eve
Nov 6, 2026
Merged

khisakuni merged 8 commits into
mainfrom
daehan/eve

Conversation

@daehan-temporal

@daehan-temporal daehan-temporal commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

What was changed

Adds Cloud CLI support for namespace payload encryption validation (EVE):

temporal cloud namespace encryption-validation get|set|enable|disable

namespace create also accepts optional --encryption-validation-* flags. If any of those flags is set, --encryption-validation-mode is required.

  • set replaces the whole nested spec. Omitted optional flags are sent as empty/false.
  • enable turns validation on. Unconfigured namespaces get defaults (warn / encoding / binary/encrypted). Disabled namespaces are re-enabled and keep metadata/inspect. Already-warn or already-deny is left unchanged. --deny only applies when turning validation on.
  • disable sets mode to disabled and keeps metadata/inspect.

Bumps go.temporal.io/cloud-sdk to v0.20.0, which includes EncryptionValidation and defaults to Cloud API v0.23.0.

Why?

Give customers a CLI to inspect and change namespace encryption-validation settings, with enable/disable for the common on/off path and set as an explicit replace.

Checklist

  1. Closes - CLDAPP-423

  2. How was this tested:

go test ./temporalcloudcli -run 'TestCreateNamespace_|TestNamespaceDescription|TestNamespaceEncryptionValidation'
  1. Any docs updates needed?
    https://docs.temporal.io/cli/command-reference/cloud/namespace

Note

Medium Risk
Touches namespace security-adjacent settings and UpdateNamespace paths; mis-flagged updates could weaken or misconfigure validation, though changes are gated behind prompts and tests.

Overview
Adds experimental Cloud CLI support for namespace payload encryption validation with temporal cloud namespace encryption-validation get|set|enable|disable and documents it in commands.yml.

Extends namespace create with optional --encryption-validation-* flags, wiring them into CreateNamespace so any partial input requires an explicit --encryption-validation-mode.

Implements set/enable/disable via GetNamespace + UpdateNamespace with prompts, resource-version/async-operation handling, guardrails (e.g., at least one flag on set, mode required when unconfigured), and adds focused unit tests covering the new flows.

Reviewed by Cursor Bugbot for commit a99976b. Bugbot is set up for automated code reviews on this repo. Configure here.

@daehan-temporal daehan-temporal self-assigned this Sep 15, 2026
@daehan-temporal
daehan-temporal requested a review from a team as a code owner September 15, 2026 07:17
@daehan-temporal
daehan-temporal marked this pull request as draft September 15, 2026 07:17

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8dd25b5. Configure here.

Comment thread temporalcloudcli/commands.yml Resolved
anekkanti
anekkanti previously approved these changes Oct 8, 2026
khisakuni
khisakuni previously approved these changes Oct 8, 2026
@khisakuni
khisakuni deployed to integration November 5, 2026 23:15 — with GitHub Actions Active
@khisakuni
khisakuni enabled auto-merge (squash) November 6, 2026 17:20
@khisakuni
khisakuni requested a review from a team as a code owner November 6, 2026 17:20
@khisakuni
khisakuni deployed to integration November 6, 2026 17:20 — with GitHub Actions Active
@khisakuni
khisakuni merged commit 88f2104 into main Nov 6, 2026
8 checks passed
@khisakuni
khisakuni deleted the daehan/eve branch November 6, 2026 17:33

This branch was successfully deployed

1 active deployment
integration — a99976b6 Deployed Nov 6, 2026 by khisakuni via Integration tests #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants