Repository navigation
Add RESOURCE_EXHAUSTED_CAUSE_SHARD_PERSISTENCE_LIMIT resource-exhausted cause - #900
Merged
Merged
Conversation
prathyushpv
marked this pull request as ready for review
November 2, 2026 17:12
yycptt
approved these changes
Nov 2, 2026
| RESOURCE_EXHAUSTED_CAUSE_BANDWIDTH_LIMIT = 11; | ||
| // Caller exceeds Nexus requests per second limit. | ||
| RESOURCE_EXHAUSTED_CAUSE_CALLER_RPS_LIMIT = 12; | ||
| // Namespace exceeds persistence rate limit on a single shard. |
Member
There was a problem hiding this comment.
should not mention Namespace here? given this can be combined with scope System
Contributor
Author
There was a problem hiding this comment.
right! I will remove this
Quinn-With-Two-Ns
approved these changes
Nov 2, 2026
Open
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Adds
RESOURCE_EXHAUSTED_CAUSE_SHARD_PERSISTENCE_LIMIT = 13to theResourceExhaustedCauseenum.Why?
The server returns
RESOURCE_EXHAUSTED_CAUSE_PERSISTENCE_LIMITboth when a namespace hits its overall persistence limit and when it hits the per-namespace, per-shard limit (history.persistencePerShardNamespaceMaxQPS), so the two can't be told apart in metrics. This follows up on #649/#654, which chose the cause enum over new scopes for this distinction.Breaking changes
None