Repository navigation
Skip visiting compute config payloads in VisitPayloads - #326
Open
zaidrain06 wants to merge 1 commit into
Open
zaidrain06 wants to merge 1 commit into
zaidrain06 wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Excluded
temporal.api.compute.v1.*messages (ComputeProvider,ComputeScaler,ComputeConfig,ComputeConfigScalingGroup,ComputeConfigScalingGroupUpdate) from payload visitation incmd/proxygenerator/interceptor.goand regeneratedproxy/interceptor.go.Updated
proxy/payload_walker_test.goand addedTestVisitPayloads_SkipsComputeConfigPayloadsinproxy/interceptor_test.go.Why?
Fixes temporalio/temporal#12970
ComputeProvider.detailsandComputeScaler.detailsaretemporal.api.common.v1.Payloadfields that store control-plane compute provider/scaler configuration read directly by the Temporal server (serialized with the default data converter), rather than end-user workflow payload data.Because
cmd/proxygenerator/interceptor.gopreviously generatedvisitPayloadstraversal for all messages transitively containingcommon.v1.Payload,NewPayloadVisitorInterceptor(and SDK payload codecs) visited and encryptedComputeProvider.detailsandComputeScaler.detailsduringCreateWorkerDeploymentVersion,UpdateWorkerDeploymentVersionComputeConfig, andValidateWorkerDeploymentVersionComputeConfig, causing the server to fail when unmarshaling the encrypted compute configuration.With this change:
CreateWorkerDeploymentVersionRequest,UpdateWorkerDeploymentVersionComputeConfigRequest,ValidateWorkerDeploymentVersionComputeConfigRequest, andComputeConfig*payloads are not visited/encrypted by payload codecs.WorkerDeploymentVersionInfostill visitsMetadata.Entrieswhile leavingComputeConfiguntouched.(cd ./cmd/proxygenerator && go run ./ -verifyOnly)andgo test -v ./proxypass.