Repository navigation
Run tests with the race detector - #325
Merged
Merged
Conversation
make test, which CI runs, now passes -race, so data races in tests fail the build. The payload visitor runs Visitor callbacks in goroutines when ConcurrencyLimit > 1, and its concurrent tests only report races under -race.
dplyukhin
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
make test, which CI runs, passes-race.Why?
The payload visitor runs
Visitorcallbacks in goroutines whenConcurrencyLimit > 1. A data race in that code only fails a test under the race detector.How did you test it?
make check testpasses with-race, about 5s for the suite.Potential risks
Tests run slower and use more memory under
-race, and CI needs cgo, whichubuntu-latestenables by default.