Repository navigation
Conversation
Gate generic Get methods behind plugin opt go127=true, deprecate package-level GetMessager when enabled, and add a manual _lab/go127 smoke module that regenerates from test/proto via buf inputs. Co-authored-by: Cursor <cursoragent@cursor.com>
wenchy
reviewed
Oct 10, 2026
| return h.mc.Load().GetMessager(name) | ||
| } | ||
|
|
||
| {{ if .Go127 }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go127=trueto emit genericHub.Get[T]/MessagerContainer.Get[T], and deprecate package-levelGetMessager[T]when enabled.go127) compatible with Go 1.24; typedGetXxxConf()accessors unchanged._lab/go127(buf inputs fromtest/proto, not wired intomake.py/CI).Test plan
python3 make.py test --lang go --no-racecd _lab/go127 && buf generate && go test ./...(Go 1.27+)Get[T]withoutgo127=trueCloses #5