Repository navigation
chore(packs): enroll ci-wall-clock and repin compound packs to 8d07118079 - #8
Merged
Merged
Conversation
…8079 Repins the systemfsoftware compound-packs source to 8d071180798f9ea82ef5a4fd877152dacc02f6b6, systemfsoftware main after #742 added the org-wide ci-wall-clock pack, and enrolls that pack beside the four already listed. packs-resolve.py resolves all five with no errors or warnings.
ryanleecode
approved these changes
Oct 13, 2026
ryanleecode
left a comment
Contributor
There was a problem hiding this comment.
Root verdict: one file, full 40-char pin 8d071180798f, resolver five roots with no errors or warnings, 12/12 green on ba32e82, 0 behind, 0 threads, MiniMax/DeepSeek peer with no Grok, constitution ruled. Compound skip accepted for a one-file repin.
systemfsoftware-maker
added a commit
that referenced
this pull request
Oct 13, 2026
…ead only TypeScript sources (U13 #2, #8) A null target (an excluded subpath) or an array target (a fallback list) failed the manifest decode, so readPackage refused the whole package with a SchemaError. Both are now admitted and skipped: neither carries a source condition. A pattern export expanded to every file under its target directory: a JSON file, a directory, and, for a root-level "./*": "./*.ts", every .ts under node_modules. Expanded candidates now pass the same TypeScript-source filter as explicit entries, and a match with an empty, ".", ".." or node_modules segment is dropped, as Node's pattern resolution rejects it. Both reader scenarios fail at e5ec09d and pass after.
systemfsoftware-maker
added a commit
that referenced
this pull request
Oct 13, 2026
…mirrored node_modules learning Supersedes the 1834 plan. U13 rules every finding of the full-path review at e5ec09d: six fixed (#1, #2, #4, #5, #6, #8), the mapped-type/infer anchor-50 note fixed after reproduction, the TS2688 regression the rerun found fixed, #3 and #7 rejected with the validator's reasons, and the Diagnostic.code refusal note made a PR4 follow-up. KTD3 now describes the mirrored node_modules ancestry instead of the explicit typeRoots chain, and the policy gains isolatedDeclarations: false. docs/profiles/2026-10-13-front-end-phases: the U13 harness at 432b608 on the corpus at 732f66a0c8. 126 of 585 shared declaration files print differently between TypeScript 7 and 5.9.3 and none are missing; every package's route and outcome match the second profile. The emit-option learning gains the isolatedDeclarations case and the types-from-node_modules case, each with its gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviews in this repository now load the org-wide
ci-wall-clockpack, and the four packs already enrolled move to systemfsoftware8d07118079, which ismainafter systemfsoftware#742 addedci-wall-clock. This repository belongs to the systemfsoftware organization, so the org-wide pack applies. The one changed file is.compound-engineering/config.yaml:ref:moves to the full SHA andpack:gainsci-wall-clock. The git source andpath:are unchanged.What the repin changes in the packs already enrolled
The new ref also brings the retained packs' current text:
boundary-testinggainsport-fakes-pass-the-port-contract.cell-architecturelosesports-separate-from-layersand changeshandle-state-privacyandservice-and-layer-boundaries.schema-lawschangesrich-type-over-foreign-encoded.package-topologychangescondition-branch-agreementand its README.No file in this repository cites the removed rule.
The 1146 plan still records the old pin and "4 roots, 0 errors" (
docs/plans/2026-10-10-1146-feat-effect-api-extractor-plan.md:317,:319,:446). This PR supersedes that record; it is not a reason to repin back todf908ddfe4. The plan is left unedited because this PR changes one file only.Resolver
I ran
packs-resolve.py(compound-engineering 3.30.3) in this checkout:--declared-only: exit 0,errors: [].errors: [],warnings: []. It returned five roots, all at8d071180798f9ea82ef5a4fd877152dacc02f6b6:cell-architecture,boundary-testing,schema-laws,package-topology,ci-wall-clock.Review receipt
Run
20261012-205646-03f29a7f:ce-code-review mode:agent base:origin/main depth:fullon headba32e821f4(base9bd73962b7). Final disposition: Ready to merge; nothing blocks it at this head. The CE report step emitted "Ready with fixes" with an empty actionable list. The validator rejected finding 3. Finding 5 (P3) is a stale row in the frozen 1146 plan that this one-file PR cannot carry. It is escalated with #6's finding 3 as root decision D2 (see #6), and under REV1 only P0 and P1 findings block.Packs loaded: all five above. Rule files read:
cell-architecture15,boundary-testing6,schema-laws10,package-topology7,ci-wall-clock12 (50 in all; READMEs are descriptions).Only one rule matches this diff:
ci-wall-clock/pr-gate-runs-only-what-the-diff-affects, through its review-invocation clause. It complies, because this review ran on the full path with every declared pack loaded. The other 49 rules do not match.Constitution: systemfsoftware
CONSTITUTION.mdat8d07118, which is identical to02bf965, outranks the pack rules andAGENTS.md. No law is violated. CONST-T12 (applicability by meaning) decided the per-rule matching.Reviewers: correctness, project standards (
AGENTS.mdplus the constitution), agent-native, learnings (the per-rule receipt above), and adversarial.Cross-model: no peer CLI is installed, and Grok routes are excluded. The adversarial pass ran through omp's
adversarial-revieweragent. Its session log shows 18 turns served by MiniMax-M3.1-Flash-Preview, 21 by deepseek-v4.1-flash, and none by Claude or Grok. Every reviewer in this run was served by MiniMax or DeepSeek.Findings and rulings:
.compound-engineering/config.yaml:5AGENTS.mddoes not tell agents to review CI-facing diffs on the full pathdocs/plans/…1146…-plan.md:446supersedes:can correct it, and that is a second file this PR does not carry. The root decides between a separate plan-supersession PR and these PR bodies as the record (CONST-S2).config.yaml:3,:5one-stuck-job-backstop; packs enforce nothing off the full pathPrivacy
Before push, I ran a whole-word grep for every private systemfsoftware repository name (54) over the diff, the commit message and this body. The only match was
AGENTS.md, which is also a common file name, and every hit is this repository's ownAGENTS.mdfile. A grep for host paths matched nothing.Re-verification (2026-10-13, head
ba32e821f4).compound-engineering/config.yaml; headba32e821f4152e4a8ed93957756afada06ef8daa, unchanged since the receipt above.packs-resolve.py, compound-engineering 3.30.3):--declared-onlyexit 0 with no errors. Full resolve exit 0 with no errors or warnings, five roots at8d071180798f9ea82ef5a4fd877152dacc02f6b6.AGENTS.md, which is this repository's own file. No host paths matched.ce-compound
ce-compoundwas evaluated for this PR (mode non-interactive) and endedDocumentation skipped. Reason: the enrollment is a config repin with no solved problem behind it. Its one lesson, that a repin can silently change rules in the packs already enrolled, is recorded above under "What the repin changes". Nothing yet detects such a change, so there is no fix to document.