Repository navigation
chore(packs): repin compound packs to systemfsoftware 0923912eed (#761) - #11
Merged
Merged
Conversation
systemfsoftware#761 merged as 0923912eedb46b34645a22d5d67f18b442c37919. At that revision the schema-laws pack no longer requires generated schema laws: law-failure-is-a-codec-defect is deleted, and refusals-beside-generated-laws is now refusal-properties-cover-unobservable-boundaries, which keeps a refusal property only where no consumer can observe the refusal. #9 retired this repository's generated laws as a declared departure from the rules pinned at 8d07118. Pinning the packs here makes that departure the house rule, so the departure is closed. The enrolled pack list is unchanged.
ryanleecode
approved these changes
Oct 13, 2026
ryanleecode
left a comment
Contributor
There was a problem hiding this comment.
Root verdict at a7d0382: one-line repin to full SHA 0923912eed (#761), resolver 5 roots 0 warnings, 12/12 green, 0 behind, 0 threads, DeepSeek review 0 findings, privacy clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviews of this repository now apply systemfsoftware's schema-laws doctrine as of #761, which no longer requires generated schema laws. That closes the declared departure #9 carried when it retired this repository's generated laws. The change is one line:
.compound-engineering/config.yamlpins the compound packs to systemfsoftware0923912eedb46b34645a22d5d67f18b442c37919instead of8d071180798f9ea82ef5a4fd877152dacc02f6b6.0923912eedis the commit #761 landed as on systemfsoftwaremain(a squash, with a single parent). The enrolled pack list is unchanged.What the new pin changes for this repository
At
0923912eed, against the old pin, for the five enrolled packs:law-failure-is-a-codec-defectis deleted.refusals-beside-generated-lawsis replaced byrefusal-properties-cover-unobservable-boundaries, which keeps a hand-written refusal property only where no consumer can observe the refusal. Five more rules and the pack README lose their generated-law premises.boundary-testing/expected-values-never-come-from-the-subjects-output,ci-wall-clock/failures-name-the-gate-and-locationandci-wall-clock/local-gate-equals-pr-gate.ci-wall-clock/red-main-reverts-its-culprit-same-day, threeboundary-testingrules,cell-architecture/service-and-layer-boundaries, and theboundary-testingandci-wall-clockREADMEs.CONSTITUTION.mdis unchanged.Nothing in the build, the tests or the shipped package reads this file. Only
ce-code-reviewand the Compound Engineering planning tools load packs from it.Pin verification
packs-resolve.py(compound-engineering 3.30.3) on this repository's own.compound-engineering/config.yaml, with--declared-onlyand full: exit 0, errors none, warnings none. All five roots (cell-architecture,boundary-testing,schema-laws,package-topology,ci-wall-clock) resolve at0923912eedb46b34645a22d5d67f18b442c37919.git fetchof0923912eedfor all five packs.0923912eedis on systemfsoftwaremain:git merge-base --is-ancestor 0923912eed 077cbc978f(the fetchedmaintip) exits 0, and the commit is first-parent onmain.a7d0382: run 38445850092 passed 11 of 11 jobs, and Changeset Check 38445849933 passed. No intent is needed, because no publishable package changes.Code review (full path, report-only, head
a7d0382)ce-code-review mode:agent base:origin/main depth:fullata7d03824eeb13538640022ef83b638b5f3c88cc6, before this PR opened. Verdict: Ready to merge: zero findings, so nothing went to validation. Reviewers: correctness, project standards (AGENTS.mdand the systemfsoftware constitution), learnings with a per-rule pack receipt, and adversarial. All four ran ondeepseek-v4.1-flash: the session logs show 17, 13, 23 and 23 turns on that model and no Claude, Grok or xAI turn. No cross-model CLI is installed here, so the adversarial lens is the peer, run in-process on that model.Pack rules (new pin, five roots, 52 top-level rule files: cell-architecture 15, boundary-testing 7, schema-laws 9, package-topology 7, ci-wall-clock 14). Each rule's
applies_whenwas judged by meaning, and none matches a review-configuration pin. The closest calls:boundary-testing/pin-dependency-semanticsrefnames review rules, not code the package links againstci-wall-clock/local-gate-equals-pr-gate(new)ci-wall-clock/failures-name-the-gate-and-location(new)schema-laws/refusal-properties-cover-unobservable-boundaries(new)cell-architecture/store-unit-of-work-handleSo no comply or violate verdict is owed. The retired rule
law-failure-is-a-codec-defectno longer exists at this pin, which is how this change closes #9's declared departure.What each reviewer raised, and its disposition:
0923912eedis on systemfsoftwaremaincould not be confirmed from a stale local cachemainancestry check (Pin verification above)0923912eeda merge commit; it is a squash-landing commit with one parentgit fetch.compound-engineering/config.yamlandconfig.local.yamlonly (packs-resolve.py:78), withconfig.yamlentries taking precedence (:709-710).config.local.yamldoes not exist in this checkout, and the resolver's output above lists only this file's five rootsce-compound: evaluated, and skipped. This is a routine repin to a published commit. The non-obvious steps (verify the SHA bygit fetchand ancestry when the API is rate-limited, check the resolved tree against the fetch) are recorded in this body. There is no new lesson to record.Privacy
Grep at head
a7d03824eeb13538640022ef83b638b5f3c88cc6over the diff againstmain, the commit message and this body:AGENTS.md, this repository's own instruction fileyounna,younna-ai,Stead,wireblast(whole word, case-insensitive)The commit author email carries the same domain as every human commit already in this repository. That is commit metadata, not diff content.