Skip to content

chore(packs): repin compound packs to systemfsoftware 0923912eed (#761) - #11

Merged
ryanleecode merged 1 commit into
mainfrom
chore/repin-packs-761
Oct 13, 2026
Merged

ryanleecode merged 1 commit into
mainfrom
chore/repin-packs-761

Conversation

@systemfsoftware-maker

@systemfsoftware-maker systemfsoftware-maker commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Reviews of this repository now apply systemfsoftware's schema-laws doctrine as of #761, which no longer requires generated schema laws. That closes the declared departure #9 carried when it retired this repository's generated laws. The change is one line: .compound-engineering/config.yaml pins the compound packs to systemfsoftware 0923912eedb46b34645a22d5d67f18b442c37919 instead of 8d071180798f9ea82ef5a4fd877152dacc02f6b6. 0923912eed is the commit #761 landed as on systemfsoftware main (a squash, with a single parent). The enrolled pack list is unchanged.

What the new pin changes for this repository

At 0923912eed, against the old pin, for the five enrolled packs:

  • schema-laws: law-failure-is-a-codec-defect is deleted. refusals-beside-generated-laws is replaced by refusal-properties-cover-unobservable-boundaries, which keeps a hand-written refusal property only where no consumer can observe the refusal. Five more rules and the pack README lose their generated-law premises.
  • New rules: boundary-testing/expected-values-never-come-from-the-subjects-output, ci-wall-clock/failures-name-the-gate-and-location and ci-wall-clock/local-gate-equals-pr-gate.
  • Reworded: ci-wall-clock/red-main-reverts-its-culprit-same-day, three boundary-testing rules, cell-architecture/service-and-layer-boundaries, and the boundary-testing and ci-wall-clock READMEs.
  • CONSTITUTION.md is unchanged.

Nothing in the build, the tests or the shipped package reads this file. Only ce-code-review and the Compound Engineering planning tools load packs from it.

Pin verification

  • packs-resolve.py (compound-engineering 3.30.3) on this repository's own .compound-engineering/config.yaml, with --declared-only and full: exit 0, errors none, warnings none. All five roots (cell-architecture, boundary-testing, schema-laws, package-topology, ci-wall-clock) resolve at 0923912eedb46b34645a22d5d67f18b442c37919.
  • The resolved pack tree is byte-identical, file by file, to a direct git fetch of 0923912eed for all five packs.
  • 0923912eed is on systemfsoftware main: git merge-base --is-ancestor 0923912eed 077cbc978f (the fetched main tip) exits 0, and the commit is first-parent on main.
  • CI at a7d0382: run 38445850092 passed 11 of 11 jobs, and Changeset Check 38445849933 passed. No intent is needed, because no publishable package changes.

Code review (full path, report-only, head a7d0382)

ce-code-review mode:agent base:origin/main depth:full at a7d03824eeb13538640022ef83b638b5f3c88cc6, before this PR opened. Verdict: Ready to merge: zero findings, so nothing went to validation. Reviewers: correctness, project standards (AGENTS.md and the systemfsoftware constitution), learnings with a per-rule pack receipt, and adversarial. All four ran on deepseek-v4.1-flash: the session logs show 17, 13, 23 and 23 turns on that model and no Claude, Grok or xAI turn. No cross-model CLI is installed here, so the adversarial lens is the peer, run in-process on that model.

Pack rules (new pin, five roots, 52 top-level rule files: cell-architecture 15, boundary-testing 7, schema-laws 9, package-topology 7, ci-wall-clock 14). Each rule's applies_when was judged by meaning, and none matches a review-configuration pin. The closest calls:

Rule Ruling Reason
boundary-testing/pin-dependency-semantics no match It covers adopting or upgrading a third-party library. A pack ref names review rules, not code the package links against
ci-wall-clock/local-gate-equals-pr-gate (new) no match No gate script, pre-push command or CI-only check changes
ci-wall-clock/failures-name-the-gate-and-location (new) no match No job or verdict step changes
schema-laws/refusal-properties-cover-unobservable-boundaries (new) no match No schema, refinement or test changes
cell-architecture/store-unit-of-work-handle no match No store port or adapter. The learnings reviewer missed this rule, so I ruled it

So no comply or violate verdict is owed. The retired rule law-failure-is-a-codec-defect no longer exists at this pin, which is how this change closes #9's declared departure.

What each reviewer raised, and its disposition:

Raised by Item Disposition
correctness, project standards Whether 0923912eed is on systemfsoftware main could not be confirmed from a stale local cache Fixed by evidence: fetched-main ancestry check (Pin verification above)
correctness The body called 0923912eed a merge commit; it is a squash-landing commit with one parent Fixed: wording corrected before opening
correctness, adversarial No automated gate re-checks that the pin resolves Rejected: a new gate needs operator approval (GATE1). The resolver runs on every review and planning invocation, as it did for this one
adversarial The new pin adds three rules that will judge future PRs Rejected as a defect: adopting #761's doctrine is the purpose of this change. The added rules are listed above
adversarial Resolution in a cold environment was not exercised Fixed by evidence: the first resolve of this pin (17:09 UTC, before review dispatch) fetched it into a new, empty cache directory, and that tree is byte-identical to a separate git fetch
adversarial Text search might miss a pin outside tracked files Rejected: the resolver reads pins from .compound-engineering/config.yaml and config.local.yaml only (packs-resolve.py:78), with config.yaml entries taking precedence (:709-710). config.local.yaml does not exist in this checkout, and the resolver's output above lists only this file's five roots

ce-compound: evaluated, and skipped. This is a routine repin to a published commit. The non-obvious steps (verify the SHA by git fetch and ancestry when the API is rate-limited, check the resolved tree against the fetch) are recorded in this body. There is no new lesson to record.

Privacy

Grep at head a7d03824eeb13538640022ef83b638b5f3c88cc6 over the diff against main, the commit message and this body:

Term Hits
All 54 private systemfsoftware repository names (list fetched earlier today) 0, apart from the file name AGENTS.md, this repository's own instruction file
Required literal terms younna, younna-ai, Stead, wireblast (whole word, case-insensitive) 0 outside this row
Host paths and credential or remote-cache token names 0

The commit author email carries the same domain as every human commit already in this repository. That is commit metadata, not diff content.

systemfsoftware#761 merged as 0923912eedb46b34645a22d5d67f18b442c37919.
At that revision the schema-laws pack no longer requires generated
schema laws: law-failure-is-a-codec-defect is deleted, and
refusals-beside-generated-laws is now
refusal-properties-cover-unobservable-boundaries, which keeps a refusal
property only where no consumer can observe the refusal.

#9 retired this repository's generated laws as a declared departure
from the rules pinned at 8d07118. Pinning the packs here makes that
departure the house rule, so the departure is closed. The enrolled pack
list is unchanged.

@ryanleecode ryanleecode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root verdict at a7d0382: one-line repin to full SHA 0923912eed (#761), resolver 5 roots 0 warnings, 12/12 green, 0 behind, 0 threads, DeepSeek review 0 findings, privacy clean.

@ryanleecode
ryanleecode merged commit 6d9d72b into main Oct 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants