Repository navigation
Conversation
DomainVerifier#verify! called casecmp? on the email domain before checking skip_domain_verification, so an auth hash without an email raised NoMethodError even with verification turned off. Without an ID token, domain_verified_jwt_claim passed nil to JWT.decode, which raises JWT::DecodeError (not rescued). Treat a missing ID token as 'claim not present' instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two crashes in `DomainVerifier#verify!`:
Specs are added for both cases. The existing "all strategies fail" spec now uses a non-nil ID token, so it still exercises the OIDC request path.
🤖 Generated with Claude Code