Repository navigation
fix: ios master builds again after the usdt and receive fixes landed together - #947
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Low impact] This change appears safe to merge. SummaryUpdates the receive error state's
Reviews (1) · Last reviewed commit: "fix: build the receive error state again..." · Reviewed by Greptile |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Fixes the master compile break where #933's error-state QrArea still passed navigationPath: / editRoute: after #884 had replaced them with onEdit. The call now uses the same editRoute(for:).map { route in { navigationPath.append(route) } } form as the populated QR at line 404. Reviewed db851cf, light tier, reasoned from the code and from CI (the iOS app is not built here).
What I checked, and 2 candidates I ruled out
Read in full: Bitkit/Views/Wallets/Receive/QrArea.swift, the three QrArea calls and editRoute(for:) in ReceiveQr.swift.
Master failure confirmed: Run Tests on 3a3ebd4e failed with ReceiveQr.swift:432 extra arguments at positions #4, #5 in call. afb57933 (#884) was green, and the merge with #933 broke it.
Call sites: no other QrArea( in the tree still passes navigationPath: or editRoute: (ReceiveQr.swift:376, :400, :432 and UsdtReceiveView.swift:187 all use onEdit). The editRoute: at ReceiveQr.swift:583 goes to CopyAddressCard, which still declares it.
CI: build-local green on this head. Run Tests and Run Integration Tests were still running at review time.
Ruled out
- Edit button behaviour changed in the error state: the old
QrAreashowed the edit button only forif let editRouteand appended it tonavigationPath. The new one shows it only for a non-nilonEdit, and.mapyields nil exactly wheneditRoute(for:)would.editRoute(for:)always returns a route, so the button stays and pushes the same.edit(...)route, includingreplacesCurrentQr. - Edit enabled with an empty URI: same as before the merge. #933 disabled only Copy and Share for an empty
uri, never Edit.
Merge confidence: 5/5, a compile fix that build-local now compiles, with no behaviour change.
Fixes the master build. #933 added a
QrAreacall for the receive error state with thenavigationPath:/editRoute:arguments, while #884 (merged just before it) replaced those with anonEditclosure. Each PR built on its own; togetherReceiveQr.swift:432fails with "extra arguments at positions #4, #5", so Run Tests, Run Integration Tests and build-local fail on master and on every open PR.Description
onEditto the error-stateQrAreathe same way the other twoQrAreacalls in this file do.QA Notes
Automated Checks
@piotr-iohk @ben-kaufman FYI, this unblocks iOS master for RC2.