Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Low impact] This formatting-only change appears safe to merge. SummaryExpands the
Reviews (1) · Last reviewed commit: "chore: wrap the activity row spacer for ..." · Reviewed by Greptile |
talosmachina
left a comment
There was a problem hiding this comment.
No findings. Wraps the one-line if !stacked { Spacer(minLength: 0) } in ActivityRowContent onto three lines so master passes the SwiftFormat lint job. Reviewed 617524f, light tier.
What I checked, and 0 candidates I ruled out
Read in full: ActivityRowContent.body around the hunk (lines 96-110 at the head)
Behaviour: none changed. The if body, condition and position inside the layout { } builder are identical, so the stacked and unstacked layouts render as before.
CI: SwiftFormat passes on this head, which is the point of the PR; Run Tests, Run Integration Tests and build-local were still pending when I reviewed. iOS does not build on this reviewer's Linux host, so this review is from the code and CI.
Merge confidence: 5/5, a whitespace-only change that a test would not apply to and the lint job it targets is green; the test jobs were still running at review time, and nothing in this diff can move them.
jvsena42
left a comment
There was a problem hiding this comment.
No issues found. The change in ActivityRow.swift:104-106 is formatting only: if !stacked { Spacer(minLength: 0) } is split across lines with the same condition, body and position. SwiftFormat and the unit and integration tests pass at 617524f; e2e-tests-local is still pending.
Device gate: no device check needed (formatting only); perf: not relevant; l10n: no UI text changed.
Refs: #1028
This PR makes
masterpass theSwiftFormatcheck again.Description
if !stacked { Spacer(minLength: 0) }inActivityRow.swiftonto its own lines. It came in with fix: improve usdt deposit accessibility #1002, merged just before chore: fix all lints and enforce warnings as errors #1028 added theSwiftFormatlint job, somasterhas failed that job since.Design
N/A — no UI changes.
Preview
N/A — no user-visible changes.
QA Notes
Journeys
N/A — no user-visible behaviour change.
Manual Tests
N/A
Automated Checks
N/A