Skip to content

chore: make master pass the swiftformat check - #1035

Closed
ovitrif wants to merge 1 commit into
masterfrom
chore/swiftformat-master-fix
Closed

ovitrif wants to merge 1 commit into
masterfrom
chore/swiftformat-master-fix

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Refs: #1028

This PR makes master pass the SwiftFormat check again.

Description

Design

N/A — no UI changes.

Preview

N/A — no user-visible changes.

QA Notes

Journeys

N/A — no user-visible behaviour change.

Manual Tests

N/A

Automated Checks

N/A

@ovitrif ovitrif added this to the 3.1.0 milestone Oct 20, 2026
@ovitrif ovitrif self-assigned this Oct 20, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T03:56:09.138292Z 617524f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This formatting-only change appears safe to merge.

Summary

Expands the if !stacked block in ActivityRow.swift onto separate lines for SwiftFormat.

  • Activity rows keep their spacer rule in SwiftFormat’s multiline style.

Reviews (1) · Last reviewed commit: "chore: wrap the activity row spacer for ..." · Reviewed by Greptile

@talosmachina talosmachina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings. Wraps the one-line if !stacked { Spacer(minLength: 0) } in ActivityRowContent onto three lines so master passes the SwiftFormat lint job. Reviewed 617524f, light tier.

What I checked, and 0 candidates I ruled out

Read in full: ActivityRowContent.body around the hunk (lines 96-110 at the head)
Behaviour: none changed. The if body, condition and position inside the layout { } builder are identical, so the stacked and unstacked layouts render as before.
CI: SwiftFormat passes on this head, which is the point of the PR; Run Tests, Run Integration Tests and build-local were still pending when I reviewed. iOS does not build on this reviewer's Linux host, so this review is from the code and CI.

Merge confidence: 5/5, a whitespace-only change that a test would not apply to and the lint job it targets is green; the test jobs were still running at review time, and nothing in this diff can move them.

@ovitrif
ovitrif requested review from a team, coreyphillips and pwltr and removed request for a team October 20, 2026 04:39

@jvsena42 jvsena42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The change in ActivityRow.swift:104-106 is formatting only: if !stacked { Spacer(minLength: 0) } is split across lines with the same condition, body and position. SwiftFormat and the unit and integration tests pass at 617524f; e2e-tests-local is still pending.

Device gate: no device check needed (formatting only); perf: not relevant; l10n: no UI text changed.

@ovitrif

ovitrif commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #1040, which makes the same ActivityRow.swift change and also fixes the two files that #871 brought in.

@ovitrif ovitrif closed this Oct 20, 2026
auto-merge was automatically disabled October 20, 2026 12:41

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants