Skip to content

test: fix two Trezor emulator UI test flakes #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mdozhdev wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

test: fix two Trezor emulator UI test flakes #1015

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f03fe3
test: wait for Trezor prompts to close and clear text fields reliably
mdozhdev Oct 19, 2026
afda99d
test: dismiss the app-wide pairing sheet and keep focus when clearing
mdozhdev Oct 20, 2026
d18b093
Merge branch 'master' into test/trezor-ui-test-fixes
piotr-iohk Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions BitkitUITests/TrezorBridgeDashboardUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,23 @@ final class TrezorBridgeDashboardUITests: XCTestCase {
app.buttons["TrezorTestHook-Pin"].tap()
XCTAssertTrue(app.otherElements["TrezorPinSheet"].waitForExistence(timeout: 5))
app.buttons["TrezorPinCancel"].tap()
XCTAssertTrue(app.otherElements["TrezorPinSheet"].waitForNonExistence(timeout: 5))

app.buttons["TrezorTestHook-Passphrase"].tap()
XCTAssertTrue(app.otherElements["TrezorPassphraseSheet"].waitForExistence(timeout: 5))
app.buttons["TrezorPassphraseCancel"].tap()
XCTAssertTrue(app.otherElements["TrezorPassphraseSheet"].waitForNonExistence(timeout: 5))

app.buttons["TrezorTestHook-Pairing"].tap()
XCTAssertTrue(app.otherElements["TrezorPairingSheet"].waitForExistence(timeout: 5))
app.buttons["TrezorPairingCancel"].tap()
let pairingSheet = app.descendants(matching: .any)["HwPairSheet"]
XCTAssertTrue(pairingSheet.waitForExistence(timeout: 5))
pairingSheet.swipeDown(velocity: .fast)
XCTAssertTrue(pairingSheet.waitForNonExistence(timeout: 5))

app.buttons["TrezorTestHook-Confirm"].tap()
XCTAssertTrue(app.otherElements["TrezorConfirmOnDeviceOverlay"].waitForExistence(timeout: 5))
app.buttons["TrezorConfirmOnDeviceCancel"].tap()
XCTAssertTrue(app.otherElements["TrezorConfirmOnDeviceOverlay"].waitForNonExistence(timeout: 5))

app.buttons["TrezorDebugLogToggle"].tap()
XCTAssertTrue(app.buttons["TrezorDebugLogClear"].waitForExistence(timeout: 5))
Expand Down Expand Up @@ -434,10 +439,8 @@ final class TrezorBridgeDashboardUITests: XCTestCase {
XCTAssertTrue(element.waitForExistence(timeout: 10), "Missing text input \(element)")
scrollTo(element)
element.tap()
if let currentValue = element.value as? String, !currentValue.isEmpty {
element.press(forDuration: 1.0)
app.menuItems["Select All"].tapIfExists()
element.typeText(XCUIKeyboardKey.delete.rawValue)
if let currentValue = element.value as? String, !currentValue.isEmpty, currentValue != element.placeholderValue {
element.typeText(String(repeating: XCUIKeyboardKey.delete.rawValue, count: currentValue.count))
}
element.typeText(text)
}
Expand Down Expand Up @@ -587,11 +590,3 @@ private final class RegtestRpcClient {
case rpc([String: Any])
}
}

private extension XCUIElement {
func tapIfExists() {
if waitForExistence(timeout: 2), isHittable {
tap()
}
}
}
Loading