Skip to content

bug: a failed disconnect drops the forced invoice refresh kept through a failed restore #999

Open

Description

@ovitrif

Refs:

What happened?

When a restore fails and a channel becomes usable meanwhile, #954 keeps a forced Lightning refresh for the public invoice. If the user then taps Disconnect and it fails (it needs the homeserver to remove the private endpoints), signOut(performSessionCleanup:) has already bumped sessionRevision in beginSessionMutation() and keeps it. After Try Again restores the same identity, preparePendingPublicPaykitInvoiceRefresh drops the kept refresh ("kept refresh dropped: identity changed"), and the publication reuses a cached invoice whose route hints can predate the new channel.

Expected behavior

A failed Disconnect that leaves the same identity keeps the pending forced refresh, so the next publication refreshes route hints for the new channel.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions