You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
bug: a payment link that crossed the pin lock is quick-paid without review #992
A lightning: link under the QuickPay threshold that reaches Bitkit while the PIN screen is up is QuickPaid as soon as it routes, with no review. @jvsena42 found two routes (comment, thread):
On master, a lightning: link opened on the terminated app is QuickPaid right after the PIN is entered.
Android opens Send for review instead: every scan that crossed the lock is marked suppressQuickPay (markDeferredScanUnlocked).
Expected behavior
A payment link that crossed the PIN lock, or waited behind a sign-in link, opens Send for review instead of QuickPay, as on Android. QuickPay still applies to links opened while Bitkit is unlocked.
Steps to Reproduce
Turn the PIN and QuickPay on, with a spending balance, and terminate Bitkit.
Open a lightning: invoice under the QuickPay threshold (optionally followed by a bitkit://pubky-auth/signin link).
Enter the PIN (and cancel the Authorize sheet when it opens).
The invoice is paid without a review screen.
Additional context
Suggested fix: carry a "crossed the lock" flag with the pending link through handleDeepLink into PaymentNavigationHelper.openPaymentSheet and skip the .quickpay view when it is set.
Activity